From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG19c-0002nu-79 for qemu-devel@nongnu.org; Tue, 18 Oct 2011 00:19:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG19b-0001EK-Am for qemu-devel@nongnu.org; Tue, 18 Oct 2011 00:19:52 -0400 Message-ID: <4E9CFE3C.80205@weilnetz.de> Date: Tue, 18 Oct 2011 06:19:08 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1318903592-4851-1-git-send-email-trev.saunders@gmail.com> In-Reply-To: <1318903592-4851-1-git-send-email-trev.saunders@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] correctly null terminate the process name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Trevor Saunders Cc: qemu-trivial , Jes Sorensen , qemu-devel@nongnu.org Am 18.10.2011 04:06, schrieb Trevor Saunders: > strncpy() doesn't garentee the copied string will be null terminated if > the original is longer than the length to copy. > > Signed-off-by: Trevor Saunders > --- > os-posix.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/os-posix.c b/os-posix.c > index dbf3b24..92dcc97 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -149,8 +149,8 @@ void os_set_proc_name(const char *s) > char name[16]; > if (!s) > return; > - name[sizeof(name) - 1] = 0; > strncpy(name, s, sizeof(name)); > + name[sizeof(name) - 1] = 0; > /* Could rewrite argv[0] too, but that's a bit more complicated. > This simple way is enough for `top'. */ > if (prctl(PR_SET_NAME, name)) { Reviewed-by: Stefan Weil