From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59906)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RGFxC-0002MH-VR
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 16:08:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RGFxA-00071t-Pu
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 16:08:02 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:33447)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RGFx9-00071Y-Ra
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 16:08:00 -0400
Received: by wyh15 with SMTP id 15so1113930wyh.4
	for <qemu-devel@nongnu.org>; Tue, 18 Oct 2011 13:07:58 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E9DDC9A.7050509@twiddle.net>
Date: Tue, 18 Oct 2011 13:07:54 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1318963843-25100-1-git-send-email-rth@twiddle.net>
	<1318963843-25100-5-git-send-email-rth@twiddle.net>
	<CAAu8pHsFyGkGTa_D+S5t_5qXhW_i7qaL7+7Lr0RiCMdPtsq2+g@mail.gmail.com>
In-Reply-To: <CAAu8pHsFyGkGTa_D+S5t_5qXhW_i7qaL7+7Lr0RiCMdPtsq2+g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/21] target-sparc: Pass float64
 parameters instead of dt0/1 temporaries.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 10/18/2011 01:04 PM, Blue Swirl wrote:
>> > -    F_HELPER(name, d)                                           \
>> > +    float64 helper_f ## name ## d (CPUState * env, float64 src1,\
>> > +                                   float64 src2)                \
>> >     {                                                           \
>> > -        DT0 = float64_ ## name (DT0, DT1, &env->fp_status);     \
>> > +        return float64_ ## name (src1, src2, &env->fp_status);  \
>> >     }                                                           \
> Could we call float64_##name() directly from generated code and avoid
> the wrapper? Translator could generate &env->fp_status and in other
> cases that could be passed around instead of env.
> 

The helper.h machinery isn't set up for that.  Also, see patch 11.


r~