From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RGI6U-0003ld-L2
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:25:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RGI6S-0000Pr-VU
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:25:46 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:43350)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RGI6S-0000Pk-R3
	for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:25:44 -0400
Received: by wwi36 with SMTP id 36so1462430wwi.10
	for <qemu-devel@nongnu.org>; Tue, 18 Oct 2011 15:25:44 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E9DFBDC.6040302@twiddle.net>
Date: Tue, 18 Oct 2011 15:21:16 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1318963843-25100-1-git-send-email-rth@twiddle.net>
	<1318963843-25100-7-git-send-email-rth@twiddle.net>
	<CAAu8pHsJgu9OywX9Dr4RrSoVOAsKAd18hSDx5SB-0dNNgaXv2A@mail.gmail.com>
In-Reply-To: <CAAu8pHsJgu9OywX9Dr4RrSoVOAsKAd18hSDx5SB-0dNNgaXv2A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/21] target-sparc: Extract common code
 for floating-point operations.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 10/18/2011 01:24 PM, Blue Swirl wrote:
>>  #ifdef TARGET_SPARC64
>> -float64 helper_fabsd(CPUState *env, float64 src)
>> +float64 helper_fabsd(float64 src)
> 
> This probably should go to previous patch.

Sure.

>> +/* Turn off the stupid always-inline hack in osdep.h.  This gets in the
>> +   way of the callback mechanisms we use in this file, generating warnings
>> +   for always-inline functions called indirectly.  */
>> +#define always_inline inline
> 
> It would be better to just delete the offending (or all) inlines.

I certainly would like to delete the offending hack in osdep.h.

The inline markers themselves are generated by def-helper.h, and are required
so that we don't wind up with a corresponding number of defined-but-not-used
errors from the helper.h definitions.

I really didn't know any one way to handle this situation that would be
immediately acceptable to everyone.  I assumed limiting the change to 
the sparc front-end would minimize the pushback.

>> +static void gen_ne_fop_FF(DisasContext *dc, int rd, int rs,
> 
> 'ne' is for no exception? How about noexcp or something?

no-exception when it's first introduced.  Then after patch 11 it would
become no-env.  Preferences for the intermediate stage?


r~