From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGI6Q-0003j9-Hx for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:25:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGI6P-0000PZ-7m for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:25:42 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:43814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGI6P-0000PU-1p for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:25:41 -0400 Received: by wyh15 with SMTP id 15so1245162wyh.4 for ; Tue, 18 Oct 2011 15:25:40 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E9DFCDF.2030100@twiddle.net> Date: Tue, 18 Oct 2011 15:25:35 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1318963843-25100-1-git-send-email-rth@twiddle.net> <1318963843-25100-10-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/21] target-sparc: Change fpr representation to doubles. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 10/18/2011 01:28 PM, Blue Swirl wrote: >> > + static const char * const fregnames[32] = { >> > + "f0", "f2", "f4", "f6", "f8", "f10", "f12", "f14", >> > + "f16", "f18", "f20", "f22", "f24", "f26", "f28", "f30", >> > + "f32", "f34", "f36", "f38", "f40", "f42", "f44", "f46", >> > + "f48", "f50", "f52", "f54", "f56", "f58", "f60", "f62", > Shouldn't these become "d0" etc? > That's what I had at first, but then after looking at the dumps for a few additional patches went back and changed it. My feeling is that these should match the disassembler, and it always uses f%d. >> - for (i = 0; i < TARGET_FPREGS; i++) >> - cpu_fpr[i] = tcg_global_mem_new_i32(TCG_AREG0, >> + for (i = 0; i < TARGET_DPREGS; i++) > Please add braces. > Sure. r~