From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGI7w-00055V-1M for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:27:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGI7u-0000XO-Hv for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:27:15 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:41120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGI7u-0000X9-82 for qemu-devel@nongnu.org; Tue, 18 Oct 2011 18:27:14 -0400 Received: by wyh15 with SMTP id 15so1246475wyh.4 for ; Tue, 18 Oct 2011 15:27:13 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E9DFD3D.4090707@twiddle.net> Date: Tue, 18 Oct 2011 15:27:09 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1318963843-25100-1-git-send-email-rth@twiddle.net> <1318963843-25100-11-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/21] tcg: Optimize some forms of deposit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 10/18/2011 01:30 PM, Blue Swirl wrote: > On Tue, Oct 18, 2011 at 6:50 PM, Richard Henderson wrote: >> If the deposit replaces the entire word, optimize to a move. >> >> If we're inserting to the top of the word, avoid the mask of arg2 >> as we'll be shifting out all of the garbage and shifting in zeros. >> >> If the host is 32-bit, reduce a 64-bit deposit to a 32-bit deposit >> when possible. >> >> Signed-off-by: Richard Henderson > > Nice patch, but why would it belong to this series? Only because we start generating a lot of these special cases in this series. It's certainly otherwise independent. r~