From: "canquan.shen" <shencanquan@huawei.com>
To: liu ping fan <pingfank@linux.vnet.ibm.com>
Cc: len.brown@intel.com, aliguori@us.ibm.com,
gong.chen@linux.intel.com, qemu-devel@nongnu.org,
seabios@seabios.org, linux-kernel@vger.kernel.org,
dave@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event
Date: Thu, 20 Oct 2011 16:34:50 +0800 [thread overview]
Message-ID: <4E9FDD2A.6010603@huawei.com> (raw)
In-Reply-To: <20111020080858.GA5808@oc8440477808.ibm.com>
On 2011/10/20 16:08, liu ping fan wrote:
> On Wed, Oct 19, 2011 at 11:50:19AM +0800, canquan.shen wrote:
>> Hi ping fan,
>> Your patch is similar with my patch, my patch name is "acpi: Fix
>> CPU hot removal problem".
> I saw your patch, a little similar. BTW, how are things going on? It is a
> long time since V0 patch
>>
This patch has reviewed by Bjorn, and I am waiting for len.brown's
response .
>> Thanks.
>> Canquan.Shen
>> 2011-10-19
>>
>> On 2011/10/19 10:53, pingfank@linux.vnet.ibm.com wrote:
>>> From: Liu Ping Fan<pingfank@linux.vnet.ibm.com>
>>>
>>> Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST
>>>
>>> Signed-off-by: Liu Ping Fan<pingfank@linux.vnet.ibm.com>
>>> ---
>>> drivers/acpi/bus.c | 2 +-
>>> drivers/acpi/scan.c | 2 +-
>>> include/acpi/acpi_bus.h | 2 ++
>>> 3 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>>> index 437ddbf..d06ec6d 100644
>>> --- a/drivers/acpi/bus.c
>>> +++ b/drivers/acpi/bus.c
>>> @@ -764,7 +764,7 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
>>> break;
>>>
>>> case ACPI_NOTIFY_EJECT_REQUEST:
>>> - /* TBD */
>>> + acpi_os_hotplug_execute(acpi_bus_hot_remove_device, handle);
>>> break;
>>>
>>> case ACPI_NOTIFY_DEVICE_CHECK_LIGHT:
>>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
>>> index 449c556..3b97b61 100644
>>> --- a/drivers/acpi/scan.c
>>> +++ b/drivers/acpi/scan.c
>>> @@ -83,7 +83,7 @@ acpi_device_modalias_show(struct device *dev, struct device_attribute *attr, cha
>>> }
>>> static DEVICE_ATTR(modalias, 0444, acpi_device_modalias_show, NULL);
>>>
>>> -static void acpi_bus_hot_remove_device(void *context)
>>> +void acpi_bus_hot_remove_device(void *context)
>>> {
>>> struct acpi_device *device;
>>> acpi_handle handle = context;
>>> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
>>> index 6cd5b64..b19c09d 100644
>>> --- a/include/acpi/acpi_bus.h
>>> +++ b/include/acpi/acpi_bus.h
>>> @@ -310,6 +310,8 @@ extern int unregister_acpi_notifier(struct notifier_block *);
>>>
>>> extern int register_acpi_bus_notifier(struct notifier_block *nb);
>>> extern void unregister_acpi_bus_notifier(struct notifier_block *nb);
>>> +extern void acpi_bus_hot_remove_device(void *context);
>>> +
>>> /*
>>> * External Functions
>>> */
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
>
> .
>
next prev parent reply other threads:[~2011-10-20 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 2:53 [Qemu-devel] [PATCH 0/1] ACPI: Call ACPI remove handler when handling ACPI eject pingfank
2011-10-19 2:53 ` [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event pingfank
2011-10-19 3:50 ` canquan.shen
2011-10-20 8:08 ` liu ping fan
2011-10-20 8:34 ` canquan.shen [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-19 2:47 [Qemu-devel] [PATCH 0/1] ACPI: Call ACPI remove handler when handling ACPI eject pingfank
2011-10-19 2:47 ` [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event pingfank
2011-10-19 13:35 ` Gong Chen
2011-10-20 9:37 ` qemulist
2011-10-21 1:37 ` Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9FDD2A.6010603@huawei.com \
--to=shencanquan@huawei.com \
--cc=aliguori@us.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=gong.chen@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).