From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGo7u-0001p1-3L for qemu-devel@nongnu.org; Thu, 20 Oct 2011 04:37:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGo7n-0003Q7-Km for qemu-devel@nongnu.org; Thu, 20 Oct 2011 04:37:21 -0400 Received: from szxga04-in.huawei.com ([119.145.14.67]:48803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGo7m-0003PJ-QB for qemu-devel@nongnu.org; Thu, 20 Oct 2011 04:37:15 -0400 Received: from huawei.com (szxga04-in [172.24.2.12]) by szxga04-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LTC00A3JVUHSS@szxga04-in.huawei.com> for qemu-devel@nongnu.org; Thu, 20 Oct 2011 16:35:05 +0800 (CST) Received: from szxrg01-dlp.huawei.com ([172.24.2.119]) by szxga04-in.huawei.com (iPlanet Messaging Server 5.2 HotFix 2.14 (built Aug 8 2006)) with ESMTP id <0LTC00CD4VUDOL@szxga04-in.huawei.com> for qemu-devel@nongnu.org; Thu, 20 Oct 2011 16:35:05 +0800 (CST) Date: Thu, 20 Oct 2011 16:34:50 +0800 From: "canquan.shen" In-reply-to: <20111020080858.GA5808@oc8440477808.ibm.com> Message-id: <4E9FDD2A.6010603@huawei.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7BIT References: <1318992821-10552-1-git-send-email-pingfank@linux.vnet.ibm.com> <1318992821-10552-2-git-send-email-pingfank@linux.vnet.ibm.com> <4E9E48FB.4010807@huawei.com> <20111020080858.GA5808@oc8440477808.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liu ping fan Cc: len.brown@intel.com, aliguori@us.ibm.com, gong.chen@linux.intel.com, qemu-devel@nongnu.org, seabios@seabios.org, linux-kernel@vger.kernel.org, dave@linux.vnet.ibm.com On 2011/10/20 16:08, liu ping fan wrote: > On Wed, Oct 19, 2011 at 11:50:19AM +0800, canquan.shen wrote: >> Hi ping fan, >> Your patch is similar with my patch, my patch name is "acpi: Fix >> CPU hot removal problem". > I saw your patch, a little similar. BTW, how are things going on? It is a > long time since V0 patch >> This patch has reviewed by Bjorn, and I am waiting for len.brown's response . >> Thanks. >> Canquan.Shen >> 2011-10-19 >> >> On 2011/10/19 10:53, pingfank@linux.vnet.ibm.com wrote: >>> From: Liu Ping Fan >>> >>> Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST >>> >>> Signed-off-by: Liu Ping Fan >>> --- >>> drivers/acpi/bus.c | 2 +- >>> drivers/acpi/scan.c | 2 +- >>> include/acpi/acpi_bus.h | 2 ++ >>> 3 files changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c >>> index 437ddbf..d06ec6d 100644 >>> --- a/drivers/acpi/bus.c >>> +++ b/drivers/acpi/bus.c >>> @@ -764,7 +764,7 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data) >>> break; >>> >>> case ACPI_NOTIFY_EJECT_REQUEST: >>> - /* TBD */ >>> + acpi_os_hotplug_execute(acpi_bus_hot_remove_device, handle); >>> break; >>> >>> case ACPI_NOTIFY_DEVICE_CHECK_LIGHT: >>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c >>> index 449c556..3b97b61 100644 >>> --- a/drivers/acpi/scan.c >>> +++ b/drivers/acpi/scan.c >>> @@ -83,7 +83,7 @@ acpi_device_modalias_show(struct device *dev, struct device_attribute *attr, cha >>> } >>> static DEVICE_ATTR(modalias, 0444, acpi_device_modalias_show, NULL); >>> >>> -static void acpi_bus_hot_remove_device(void *context) >>> +void acpi_bus_hot_remove_device(void *context) >>> { >>> struct acpi_device *device; >>> acpi_handle handle = context; >>> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h >>> index 6cd5b64..b19c09d 100644 >>> --- a/include/acpi/acpi_bus.h >>> +++ b/include/acpi/acpi_bus.h >>> @@ -310,6 +310,8 @@ extern int unregister_acpi_notifier(struct notifier_block *); >>> >>> extern int register_acpi_bus_notifier(struct notifier_block *nb); >>> extern void unregister_acpi_bus_notifier(struct notifier_block *nb); >>> +extern void acpi_bus_hot_remove_device(void *context); >>> + >>> /* >>> * External Functions >>> */ >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > > > . >