From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGoPm-0005Az-EI for qemu-devel@nongnu.org; Thu, 20 Oct 2011 04:55:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGoPi-0006Z9-8v for qemu-devel@nongnu.org; Thu, 20 Oct 2011 04:55:50 -0400 Received: from mail-pz0-f43.google.com ([209.85.210.43]:56653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGoPi-0006Yy-1m for qemu-devel@nongnu.org; Thu, 20 Oct 2011 04:55:46 -0400 Received: by pzk33 with SMTP id 33so6616306pzk.2 for ; Thu, 20 Oct 2011 01:55:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E9FE20A.5020000@redhat.com> Date: Thu, 20 Oct 2011 10:55:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1319097820-4788-1-git-send-email-sdb@zubnet.me.uk> In-Reply-To: <1319097820-4788-1-git-send-email-sdb@zubnet.me.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , sdb@zubnet.me.uk On 10/20/2011 10:03 AM, Stuart Brady wrote: > Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() > respectively, in cases where the return value is casted to the same > type as specified using sizeof() in the parameter to g_malloc() and > assigned to a variable of that type. This is likely to cause conflicts all over the place, and now is a very bad time to do so :( because people are trying to get their patches in during the soft feature freeze. I don't oppose the change, just the timing. Paolo