From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGpVf-00034g-TM for qemu-devel@nongnu.org; Thu, 20 Oct 2011 06:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGpVe-0004ay-67 for qemu-devel@nongnu.org; Thu, 20 Oct 2011 06:05:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGpVd-0004ap-V7 for qemu-devel@nongnu.org; Thu, 20 Oct 2011 06:05:58 -0400 Message-ID: <4E9FF328.1070704@redhat.com> Date: Thu, 20 Oct 2011 12:08:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1319036398-14320-1-git-send-email-pbonzini@redhat.com> <1319036398-14320-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1319036398-14320-9-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 8/8] block: change discard to co_discard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 19.10.2011 16:59, schrieb Paolo Bonzini: > Since coroutine operation is now mandatory, convert both bdrv_discard > implementations to coroutines. For qcow2, this means taking the lock > around the operation. raw-posix remains synchronous. > > The bdrv_discard callback is then unused and can be eliminated. > > Signed-off-by: Paolo Bonzini Reviewed-by: Kevin Wolf