From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGpd0-0006C6-FI for qemu-devel@nongnu.org; Thu, 20 Oct 2011 06:13:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGpcz-0005p1-Cn for qemu-devel@nongnu.org; Thu, 20 Oct 2011 06:13:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGpcy-0005oL-Q6 for qemu-devel@nongnu.org; Thu, 20 Oct 2011 06:13:33 -0400 Message-ID: <4E9FF448.2080708@redhat.com> Date: Thu, 20 Oct 2011 12:13:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1319036398-14320-1-git-send-email-pbonzini@redhat.com> <1319036398-14320-2-git-send-email-pbonzini@redhat.com> <4E9FE674.30101@redhat.com> In-Reply-To: <4E9FE674.30101@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] vpc: detect floppy disk geometries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 10/20/2011 11:14 AM, Kevin Wolf wrote: >> > diff --git a/block/vpc.c b/block/vpc.c >> > index cb6c570..549a632 100644 >> > --- a/block/vpc.c >> > +++ b/block/vpc.c >> > @@ -463,6 +463,14 @@ static int calculate_geometry(int64_t total_sectors, uint16_t* cyls, >> > { >> > uint32_t cyls_times_heads; >> > >> > + if (total_sectors<= 5760) { >> > + /* Floppy disk geometry */ > Please state in the comment that this part is deviating from the > algorithm in the VHD spec, which this function is generally supposed to > implement. Hmm, looks like virtual PC uses a separate "VFD" image for floppies, so I can drop this. Paolo