From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39474)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RGtSR-0005iN-H6
	for qemu-devel@nongnu.org; Thu, 20 Oct 2011 10:18:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RGtSP-0007Rf-RU
	for qemu-devel@nongnu.org; Thu, 20 Oct 2011 10:18:55 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51590 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RGtSP-0007RR-HI
	for qemu-devel@nongnu.org; Thu, 20 Oct 2011 10:18:53 -0400
Message-ID: <4EA02DCC.4020906@suse.de>
Date: Thu, 20 Oct 2011 16:18:52 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1318251148-2931-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1318251148-2931-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in
	cpu_arm_close()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Am 10.10.2011 14:52, schrieb Andreas F=C3=A4rber:
> env is allocated in cpu_arm_init() with g_malloc0(), so free with g_fre=
e().
>=20
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  target-arm/helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index d3a3ba2..8195c56 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -471,7 +471,7 @@ static uint32_t cpu_arm_find_by_name(const char *na=
me)
> =20
>  void cpu_arm_close(CPUARMState *env)
>  {
> -    free(env);
> +    g_free(env);
>  }
> =20
>  uint32_t cpsr_read(CPUARMState *env)

Ping! Didn't see this in the pull request... Should it go through
qemu-trivial instead?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746, AG N=C3=
=BCrnberg