From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RH8hQ-0004ct-N2 for qemu-devel@nongnu.org; Fri, 21 Oct 2011 02:35:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RH8hP-0004cV-JF for qemu-devel@nongnu.org; Fri, 21 Oct 2011 02:35:24 -0400 Sender: Paolo Bonzini Message-ID: <4EA112A4.5000106@redhat.com> Date: Fri, 21 Oct 2011 08:35:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1318958255-14008-1-git-send-email-pavel.borzenkov@gmail.com> <20111020172301.GA14359@stefanha-thinkpad.localdomain> In-Reply-To: <20111020172301.GA14359@stefanha-thinkpad.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Pavel Borzenkov On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote: > On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote: >> Spotted by Clang Analyzer >> >> Signed-off-by: Pavel Borzenkov >> --- >> block/qed.c | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) > > Thanks, applied to the trivial patches tree: > http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches I think there are other places in the tree where we assume that "memcpy(dest, NULL, 0);" works. Paolo