From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RH9fD-0001G5-Dd for qemu-devel@nongnu.org; Fri, 21 Oct 2011 03:37:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RH9fB-0006YV-Dn for qemu-devel@nongnu.org; Fri, 21 Oct 2011 03:37:11 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:59391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RH9fB-0006YR-4c for qemu-devel@nongnu.org; Fri, 21 Oct 2011 03:37:09 -0400 Received: by ywp17 with SMTP id 17so4382084ywp.4 for ; Fri, 21 Oct 2011 00:37:08 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4EA1211E.2020709@redhat.com> Date: Fri, 21 Oct 2011 09:37:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1319097820-4788-1-git-send-email-sdb@zubnet.me.uk> <1319097820-4788-5-git-send-email-sdb@zubnet.me.uk> <4E9FE45D.5020802@redhat.com> <20111021002603.GA6139@zubnet.me.uk> In-Reply-To: <20111021002603.GA6139@zubnet.me.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stuart Brady Cc: qemu-devel@nongnu.org On 10/21/2011 02:26 AM, Stuart Brady wrote: >> > They all look okay, perhaps the include path you passed to >> > Coccinelle is incomplete? > Ah, good point! I'm not sure what include dirs are needed, though... > anyone have any advice? > > Blue Swirl, I gather you're one of the few other people to have used > Coccinelle with Qemu's source... I played a bit yesterday and it turns out that Coccinelle is a bit limited WRT handling headers, because they are very expensive. I used "-I . -I +build -I hw" but it didn't help much. Stuart/Blue, do you have a macro file? Mine was simply "#define coroutine_fn". Paolo