From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHBZR-00064e-2r for qemu-devel@nongnu.org; Fri, 21 Oct 2011 05:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHBZP-0003IE-Hv for qemu-devel@nongnu.org; Fri, 21 Oct 2011 05:39:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHBZP-0003Hp-3T for qemu-devel@nongnu.org; Fri, 21 Oct 2011 05:39:19 -0400 Message-ID: <4EA13E7D.9040105@redhat.com> Date: Fri, 21 Oct 2011 11:42:21 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1319109385-7927-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1319109385-7927-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/7] finish coroutinization of drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 20.10.2011 13:16, schrieb Paolo Bonzini: > Drivers that only implement the bdrv_read and bdrv_write callbacks > were unwillingly converted to be reentrant when bdrv_read and > bdrv_write were changed to always create coroutines. So, > we need locks aroudn read and write operations. > > This series does this (patches 4-6) and removes the flush/discard > callbacks that, as it turns out, are really duplicates of co_flush > and co_discard (patches 7-8). > > Patches 1-2 are cleanups that I discovered while testing. > > v1->v2: rwlock->mutex, convert read-only drivers too, drop vpc change > > Paolo Bonzini (7): > vmdk: fix return values of vmdk_parent_open > vmdk: clean up open > block: add a CoMutex to synchronous read drivers > block: take lock around bdrv_read implementations > block: take lock around bdrv_write implementations > block: change flush to co_flush > block: change discard to co_discard Thanks, applied all to the block branch. Kevin