From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RHE6n-0006F2-SH
	for qemu-devel@nongnu.org; Fri, 21 Oct 2011 08:21:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RHE6m-0001L6-O8
	for qemu-devel@nongnu.org; Fri, 21 Oct 2011 08:21:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53299)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RHE6m-0001L0-9m
	for qemu-devel@nongnu.org; Fri, 21 Oct 2011 08:21:56 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9LCLspp023748
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 21 Oct 2011 08:21:54 -0400
Message-ID: <4EA163DF.5070309@redhat.com>
Date: Fri, 21 Oct 2011 14:21:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com>
	<1318503845-11473-14-git-send-email-pbonzini@redhat.com>
	<4EA15F0F.8040006@redhat.com>
In-Reply-To: <4EA15F0F.8040006@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 13/35] scsi: move tcq/ndev to SCSIBusOps
 (now SCSIBusInfo)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/21/2011 02:01 PM, Kevin Wolf wrote:
>> >
>> >  -static const struct SCSIBusOps vscsi_scsi_ops = {
>> >  +static const struct SCSIBusInfo vscsi_scsi_info = {
>> >  +    .tcq = true,
>> >  +    .ndev = 63, /* logical unit addressing format */
> This is a change from VSCSI_REQ_LIMIT = 24. This may be a bugfix or not
> - I don't know the hardware - but it's matter for a separate patch.

Ok, will leave 24.

Paolo