From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHEpi-00066X-Ut for qemu-devel@nongnu.org; Fri, 21 Oct 2011 09:08:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHEph-0003HB-SO for qemu-devel@nongnu.org; Fri, 21 Oct 2011 09:08:22 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:48959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHEph-0003H2-L2 for qemu-devel@nongnu.org; Fri, 21 Oct 2011 09:08:21 -0400 Received: by ggnr5 with SMTP id r5so4672837ggn.4 for ; Fri, 21 Oct 2011 06:08:21 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4EA16EBD.7070904@redhat.com> Date: Fri, 21 Oct 2011 15:08:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1318503845-11473-1-git-send-email-pbonzini@redhat.com> <1318503845-11473-13-git-send-email-pbonzini@redhat.com> <4EA15D64.3050108@redhat.com> In-Reply-To: <4EA15D64.3050108@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/35] scsi-disk: report media changed via GET EVENT STATUS NOTIFICATION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 10/21/2011 01:54 PM, Kevin Wolf wrote: >> This adds support for media change notification via the GET EVENT STATUS >> > NOTIFICATION command, used by Linux versions 2.6.38 and newer. >> > >> > Signed-off-by: Paolo Bonzini > Looks good, but the ATAPI version of the code is somewhat nicer to read. Yeah, on the other hand even the ATAPI version has a mix of structs and buffers (in event_status_media, which also assumes sizeof gesn_event_header == 4). Paolo