From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHK5F-0006rc-Br for qemu-devel@nongnu.org; Fri, 21 Oct 2011 14:44:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHK5E-0004JJ-AC for qemu-devel@nongnu.org; Fri, 21 Oct 2011 14:44:45 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:35450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHK5E-0004JB-1D for qemu-devel@nongnu.org; Fri, 21 Oct 2011 14:44:44 -0400 Received: by ggnr5 with SMTP id r5so5033227ggn.4 for ; Fri, 21 Oct 2011 11:44:42 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4EA1BD95.8030205@redhat.com> Date: Fri, 21 Oct 2011 20:44:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1319216912-26964-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1319216912-26964-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, avi@redhat.com On 10/21/2011 07:08 PM, Kevin Wolf wrote: > Avi complained that not even writing out qcow2's cache on bdrv_flush() made > cache=unsafe too unsafe to be useful. He's got a point. Why? cache=unsafe is explicitly allowing to s/data/manure/ on crash. If you do this for raw-posix, you need to do it for all protocols. > Kevin Wolf (2): > raw-posix: Convert to bdrv_co_flush > block: Handle cache=unsafe only in raw-posix/win32 Paolo