From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RHZdi-0001Co-42
	for qemu-devel@nongnu.org; Sat, 22 Oct 2011 07:21:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RHZdg-0006sx-Gz
	for qemu-devel@nongnu.org; Sat, 22 Oct 2011 07:21:21 -0400
Received: from fmmailgate04.web.de ([217.72.192.242]:45133)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RHZdf-0006s8-QH
	for qemu-devel@nongnu.org; Sat, 22 Oct 2011 07:21:20 -0400
Message-ID: <4EA2A72D.4080408@web.de>
Date: Sat, 22 Oct 2011 13:21:17 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1319278273-32437-1-git-send-email-khansa@kics.edu.pk>
In-Reply-To: <1319278273-32437-1-git-send-email-khansa@kics.edu.pk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: andreas.faerber@web.de
Subject: Re: [Qemu-devel] [PATCH v3 0/6] MIPS64 user mode emulation in QEMU
 with Cavium specific instruction support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: khansa@kics.edu.pk
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, aurelien@aurel32.net

Am 22.10.2011 12:11, schrieb khansa@kics.edu.pk:
> From: Khansa Butt <khansa@kics.edu.pk>
> 
> This is the team work of Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt
> from HPCN Lab KICS UET Lahore.
> 
> Sorry Richard! gen_set was missed.

When I say further description is missing, I mean: Please add at least
one sentence between From: and Signed-off-by: summarizing what changes
you are doing and why those are correct. This is very useful for
bisecting, git log and web interfaces.
And if you're fixing a bug, please describe what symptoms there were
(crash? wrong values? etc.) so that it can be verified and checked for
future regressions.

Remember, most of us are not too intimate with mips.

Andreas

> v1 contains:
> * SEQI and SEQ related changes specified by Richard Henderson
> * Fix issues related to coding style, typos and misleading comments
> * Cavium specific change in set_thread_area syscall has been removed
> *  as it corresponds to modified libc and kernel.