From: Jan Kiszka <jan.kiszka@web.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>,
Harsh Prateek Bora <harsh@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers
Date: Sun, 23 Oct 2011 15:54:59 +0200 [thread overview]
Message-ID: <4EA41CB3.9060405@web.de> (raw)
In-Reply-To: <87y5we4byh.fsf@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3140 bytes --]
On 2011-10-21 17:10, Aneesh Kumar K.V wrote:
> On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> Hi.
>>
>> Current git head build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers.
>> Error messages:
>>
>> In file included from trace.c:2:0:
>> trace.h: In function ‘trace_v9fs_attach’:
>> trace.h:2850:9: error: too many arguments for format [-Werror=format-extra-args]
>> trace.h: In function ‘trace_v9fs_wstat’:
>> trace.h:3039:9: error: too many arguments for format [-Werror=format-extra-args]
>> trace.h: In function ‘trace_v9fs_mkdir’:
>> trace.h:3088:9: error: too many arguments for format [-Werror=format-extra-args]
>> trace.h: In function ‘trace_v9fs_mkdir_return’:
>> trace.h:3095:9: error: too many arguments for format [-Werror=format-extra-args]
>> cc1: all warnings being treated as errors
>>
>> Prototypes in the trace-events do not match format strings, e.g.
>>
>> v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char* uname, char* aname) "tag %d id %d fid %d afid %d aname %s"
>>
>> The following patch fixes it, but I'm not sure the format lines are appropriate.
>
> Can you send the patch with signed-off-by: I will add it in the next
> pull request.
There are more breakages with tracing enabled:
CC libhw64/9pfs/virtio-9p.o
cc1: warnings being treated as errors
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_create’:
/data/qemu/hw/9pfs/virtio-9p.c:2225:9: error: ‘iounit’ may be used uninitialized in this function
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_readdir’:
/data/qemu/hw/9pfs/virtio-9p.c:2063:13: error: ‘count’ may be used uninitialized in this function
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_xattrwalk’:
/data/qemu/hw/9pfs/virtio-9p.c:3103:13: error: ‘size’ may be used uninitialized in this function
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_lcreate’:
/data/qemu/hw/9pfs/virtio-9p.c:1730:13: error: ‘iounit’ may be used uninitialized in this function
/data/qemu/hw/9pfs/virtio-9p.c: In function ‘v9fs_open’:
/data/qemu/hw/9pfs/virtio-9p.c:1651:9: error: ‘iounit’ may be used uninitialized in this function
Not sure what the undefined variables are supposed to contain for the
trace output, so I refrain from writing any patch.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-10-23 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 19:20 [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers Max Filippov
2011-10-20 19:24 ` Stefan Weil
2011-10-21 15:10 ` Aneesh Kumar K.V
2011-10-23 13:54 ` Jan Kiszka [this message]
2011-10-24 6:16 ` Aneesh Kumar K.V
2011-10-24 8:11 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA41CB3.9060405@web.de \
--to=jan.kiszka@web.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=harsh@linux.vnet.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).