From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHyW0-0001hh-Bv for qemu-devel@nongnu.org; Sun, 23 Oct 2011 09:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHyVy-0001ZZ-Sb for qemu-devel@nongnu.org; Sun, 23 Oct 2011 09:55:04 -0400 Received: from fmmailgate07.web.de ([217.72.192.248]:46175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHyVy-0001ZD-Gf for qemu-devel@nongnu.org; Sun, 23 Oct 2011 09:55:02 -0400 Message-ID: <4EA41CB3.9060405@web.de> Date: Sun, 23 Oct 2011 15:54:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <201110202320.54504.jcmvbkbc@gmail.com> <87y5we4byh.fsf@linux.vnet.ibm.com> In-Reply-To: <87y5we4byh.fsf@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigAD67EE6156EAF807003B07E3" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: Max Filippov , Harsh Prateek Bora , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAD67EE6156EAF807003B07E3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-10-21 17:10, Aneesh Kumar K.V wrote: > On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov w= rote: >> Hi. >> >> Current git head build with trace enabled is broken by the commit c572= f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pd= u handlers. >> Error messages: >> >> In file included from trace.c:2:0: >> trace.h: In function =E2=80=98trace_v9fs_attach=E2=80=99: >> trace.h:2850:9: error: too many arguments for format [-Werror=3Dformat= -extra-args] >> trace.h: In function =E2=80=98trace_v9fs_wstat=E2=80=99: >> trace.h:3039:9: error: too many arguments for format [-Werror=3Dformat= -extra-args] >> trace.h: In function =E2=80=98trace_v9fs_mkdir=E2=80=99: >> trace.h:3088:9: error: too many arguments for format [-Werror=3Dformat= -extra-args] >> trace.h: In function =E2=80=98trace_v9fs_mkdir_return=E2=80=99: >> trace.h:3095:9: error: too many arguments for format [-Werror=3Dformat= -extra-args] >> cc1: all warnings being treated as errors >> >> Prototypes in the trace-events do not match format strings, e.g. >> >> v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char*= uname, char* aname) "tag %d id %d fid %d afid %d aname %s" >> >> The following patch fixes it, but I'm not sure the format lines are ap= propriate. >=20 > Can you send the patch with signed-off-by: I will add it in the next > pull request. There are more breakages with tracing enabled: CC libhw64/9pfs/virtio-9p.o cc1: warnings being treated as errors /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_create=E2=80=99= : /data/qemu/hw/9pfs/virtio-9p.c:2225:9: error: =E2=80=98iounit=E2=80=99 ma= y be used uninitialized in this function = = =20 /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_readdir=E2=80=99= : /data/qemu/hw/9pfs/virtio-9p.c:2063:13: error: =E2=80=98count=E2=80=99 ma= y be used uninitialized in this function = = =20 /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_xattrwalk=E2=80= =99: /data/qemu/hw/9pfs/virtio-9p.c:3103:13: error: =E2=80=98size=E2=80=99 may= be used uninitialized in this function = = =20 /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_lcreate=E2=80=99= : /data/qemu/hw/9pfs/virtio-9p.c:1730:13: error: =E2=80=98iounit=E2=80=99 m= ay be used uninitialized in this function = = =20 /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_open=E2=80=99: /data/qemu/hw/9pfs/virtio-9p.c:1651:9: error: =E2=80=98iounit=E2=80=99 ma= y be used uninitialized in this function = = =20 Not sure what the undefined variables are supposed to contain for the trace output, so I refrain from writing any patch. Jan --------------enigAD67EE6156EAF807003B07E3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6kHLMACgkQitSsb3rl5xS+ZwCfV83h524rSbDQhWxYDgCukjVy 7ewAoMqca31T+xJpjfXdPbFe604HXUVB =urP/ -----END PGP SIGNATURE----- --------------enigAD67EE6156EAF807003B07E3--