From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIH1W-0005b0-0e for qemu-devel@nongnu.org; Mon, 24 Oct 2011 05:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIH1U-0002KR-Oe for qemu-devel@nongnu.org; Mon, 24 Oct 2011 05:40:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIH1U-0002KI-8K for qemu-devel@nongnu.org; Mon, 24 Oct 2011 05:40:48 -0400 Message-ID: <4EA5329C.3000003@redhat.com> Date: Mon, 24 Oct 2011 11:40:44 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1319216912-26964-1-git-send-email-kwolf@redhat.com> <4EA1BD95.8030205@redhat.com> <4EA515B9.8070204@redhat.com> <4EA51963.5060904@redhat.com> <4EA51F16.3030700@redhat.com> <4EA5262D.7090901@redhat.com> <4EA527DC.90902@redhat.com> <4EA52F2E.4000302@redhat.com> <4EA53184.8080201@redhat.com> In-Reply-To: <4EA53184.8080201@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] block: Write out internal caches even with cache=unsafe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: avi@redhat.com, Alexander Graf , qemu-devel@nongnu.org On 10/24/2011 11:36 AM, Kevin Wolf wrote: >> > You're changing the API and asking for possibly non-trivial changes in >> > all protocol drivers, in order to accomodate semantics that all format >> > drivers potentially could desire. So I wonder if the problem is simply >> > that the current API is not expressive enough. > Can you think of any cases where a caller would want to invoke > bdrv_flush, but not bdrv_fsync? (The other way round it makes even less > sense) I'm talking about the internal driver API only. The external API is fine as is. Paolo