From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIMDL-0005zc-4z for qemu-devel@nongnu.org; Mon, 24 Oct 2011 11:13:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIMDG-0008J0-Is for qemu-devel@nongnu.org; Mon, 24 Oct 2011 11:13:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIMDG-0008Iu-8E for qemu-devel@nongnu.org; Mon, 24 Oct 2011 11:13:18 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9OFDGWJ031955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Oct 2011 11:13:17 -0400 Message-ID: <4EA5808A.7050409@redhat.com> Date: Mon, 24 Oct 2011 17:13:14 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1319457739-14562-1-git-send-email-alevy@redhat.com> <1319457739-14562-2-git-send-email-alevy@redhat.com> In-Reply-To: <1319457739-14562-2-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] monitor: screen_dump async List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org, mlureau@redhat.com, armbru@redhat.com, lcapitulino@redhat.com On 10/24/11 14:02, Alon Levy wrote: > Make screen_dump monitor command an async command to allow next for qxl > to implement it as a initiating call to red_worker and completion on > callback, to fix a deadlock when issueing a screendump command via > libvirt while connected with a libvirt controlled spice-gtk client. Approach looks reasonable to me. Patch breaks the build though, you've missed a bunch of screen_dump functions in non-x86 targets. cheers, Gerd