From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIcA1-0001Di-0D for qemu-devel@nongnu.org; Tue, 25 Oct 2011 04:15:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIc9z-0003l6-OF for qemu-devel@nongnu.org; Tue, 25 Oct 2011 04:15:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIc9z-0003kt-Fu for qemu-devel@nongnu.org; Tue, 25 Oct 2011 04:14:59 -0400 Message-ID: <4EA6709F.60305@redhat.com> Date: Tue, 25 Oct 2011 10:17:35 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1316597875-30463-1-git-send-email-ronniesahlberg@gmail.com> <1316597875-30463-2-git-send-email-ronniesahlberg@gmail.com> <4EA56939.9070609@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ronnie sahlberg Cc: stefanha@linux.vnet.ibm.com, dlaor@redhat.com, qemu-devel@nongnu.org, fujita.tomonori@lab.ntt.co.jp, owasserm@redhat.com, pbonzini@redhat.com, hch@lst.de Am 25.10.2011 10:04, schrieb ronnie sahlberg: >> iscsi_destroy_url() is only ever called here. Do we leak it in the normal path? > > It didnt leak but the the label was confusing. I have changed it from > "failed" to "finished" since this part > is executed for both normal and failures. But there's a return 0; immediately before the label? Kevin