From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RIlHC-0006cA-Q6
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 13:59:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RIlHB-0002zu-BG
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 13:59:02 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:62189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1RIlHB-0002zZ-55
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 13:59:01 -0400
Received: by wwi36 with SMTP id 36so1115590wwi.10
	for <qemu-devel@nongnu.org>; Tue, 25 Oct 2011 10:58:59 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4EA6F8DE.1080700@twiddle.net>
Date: Tue, 25 Oct 2011 10:58:54 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1319550280.git.quintela@redhat.com>
	<2990903a0cc46441449790bcdb216c9b5c895507.1319550280.git.quintela@redhat.com>
In-Reply-To: <2990903a0cc46441449790bcdb216c9b5c895507.1319550280.git.quintela@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/25] vmstate: make all architectures
 export a way to migrate cpu's
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, Paul Brook <paul@codesourcery.com>, Aurelien Jarno <aurelien@aurel32.net>

On 10/25/2011 07:00 AM, Juan Quintela wrote:
> This makes several changes:
> - exports VMStateDescription vmstate_cpu non-static.
> - makes sure that every cpu has a vmstate_cpu or cpu_save/load defined
> - for the architecture that had nothing, it just register the cpu as unmigratable.
> - Depending on CPU_SAVE_VERSION we register old/new migration style
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> CC: Richard Henderson <rth@twiddle.net>
> CC: Michael Walle <michael@walle.cc>
> CC: Paul Brook <paul@codesourcery.com>
> CC: Alexander Graf <agraf@suse.de>
> CC: Aurelien Jarno <aurelien@aurel32.net>
> CC: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  exec.c                  |    2 ++
>  hw/hw.h                 |    2 ++
>  target-alpha/machine.c  |   12 +-----------
>  target-i386/machine.c   |    2 +-
>  target-lm32/machine.c   |    2 +-
>  target-m68k/machine.c   |   10 ++++++++++
>  target-s390x/machine.c  |   14 ++++++--------
>  target-sh4/machine.c    |   10 ++++++++++
>  target-xtensa/machine.c |   14 ++++++--------

...

> --- a/target-alpha/machine.c
> +++ b/target-alpha/machine.c
> @@ -68,20 +68,10 @@ static VMStateField vmstate_cpu_fields[] = {
>      VMSTATE_END_OF_LIST()
>  };
> 
> -static const VMStateDescription vmstate_cpu = {
> +const VMStateDescription vmstate_cpu = {
>      .name = "cpu",
>      .version_id = 1,
>      .minimum_version_id = 1,
>      .minimum_version_id_old = 1,
>      .fields = vmstate_cpu_fields,
>  };
> -
> -void cpu_save(QEMUFile *f, void *opaque)
> -{
> -    vmstate_save_state(f, &vmstate_cpu, opaque);
> -}
> -
> -int cpu_load(QEMUFile *f, void *opaque, int version_id)
> -{
> -    return vmstate_load_state(f, &vmstate_cpu, opaque, version_id);
> -}

Acked-by: Richard Henderson <rth@twiddle.net>


r~