From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RImpf-0000B7-Sn
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 15:38:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RImpe-0005pg-Vo
	for qemu-devel@nongnu.org; Tue, 25 Oct 2011 15:38:43 -0400
Message-ID: <4EA7103A.8080809@freescale.com>
Date: Tue, 25 Oct 2011 14:38:34 -0500
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
References: <1318569548-8537-1-git-send-email-david@gibson.dropbear.id.au>
	<EFBE2537-276B-4790-B3B4-45C9EB169585@suse.de>
	<20111014063631.GD4580@truffala.fritz.box>
	<600B92AB-F318-4F7B-BF88-C142BB2676F3@suse.de>
In-Reply-To: <600B92AB-F318-4F7B-BF88-C142BB2676F3@suse.de>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related
 kvm exits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On 10/14/2011 01:44 AM, Alexander Graf wrote:
> Wouldn't a simple
> 
> if (kvm_enabled()) {
>     return;
> }
> 
> in the beginning of the function make more sense? There's no code connecting the in-qemu and the in-kvm decrementors atm, so any logic applying to the in-qemu one is moot for kvm.

On book3e at least, we can use sregs to set the decrementer, and we
probably want this to happen on reset.

-Scott