[Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Lucas Meneghel Rodrigues]

Hi folks:

We've captured a regression with floppy disk on recent qemu (and 
qemu-kvm, after a code merge). We bisected it to be caused by:

commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson <rth@twiddle.net>
Date:   Mon Aug 15 15:08:45 2011 -0700

     fdc: Convert to isa_register_portio_list

     Signed-off-by: Richard Henderson <rth@twiddle.net>
     Signed-off-by: Avi Kivity <avi@redhat.com>

Since this commit, the guest doesn't see a floppy disk attached to it 
anymore, blocking kvm autotest ability to install windows guests 
automatically. This is a big deal for kvm autotest (ruins our automated 
regression jobs), so please take a look at it.

Cheers,

Lucas and Cleber

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Kevin Wolf]

Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
> Hi folks:
> 
> We've captured a regression with floppy disk on recent qemu (and 
> qemu-kvm, after a code merge). We bisected it to be caused by:
> 
> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
> Author: Richard Henderson <rth@twiddle.net>
> Date:   Mon Aug 15 15:08:45 2011 -0700
> 
>      fdc: Convert to isa_register_portio_list
> 
>      Signed-off-by: Richard Henderson <rth@twiddle.net>
>      Signed-off-by: Avi Kivity <avi@redhat.com>
> 
> Since this commit, the guest doesn't see a floppy disk attached to it 
> anymore, blocking kvm autotest ability to install windows guests 
> automatically. This is a big deal for kvm autotest (ruins our automated 
> regression jobs), so please take a look at it.

Can you please try again with the latest block branch? I think there is
a patch queued that will fix it.

Kevin

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Cleber Rosa]

On 10/26/2011 12:47 PM, Kevin Wolf wrote:
> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>> Hi folks:
>>
>> We've captured a regression with floppy disk on recent qemu (and
>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>
>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>> Author: Richard Henderson<rth@twiddle.net>
>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>
>>       fdc: Convert to isa_register_portio_list
>>
>>       Signed-off-by: Richard Henderson<rth@twiddle.net>
>>       Signed-off-by: Avi Kivity<avi@redhat.com>
>>
>> Since this commit, the guest doesn't see a floppy disk attached to it
>> anymore, blocking kvm autotest ability to install windows guests
>> automatically. This is a big deal for kvm autotest (ruins our automated
>> regression jobs), so please take a look at it.
> Can you please try again with the latest block branch? I think there is
> a patch queued that will fix it.
>
> Kevin

Kevin,

The behaviour of the latest block branch is indeed different, but not 
much better.

In my quick manual test, booting via a FreeDOS floppy image:

* latest master: does not seem to read the floppy at all
* latest block: reads the floppy only to the point that 'FreeDOS' is 
printed in the console

All other qemu/qemu-kvm versions tested (for example 0.15.0), 
successfully read and boot the same image.

CR.

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Cleber Rosa]

On 10/26/2011 12:47 PM, Kevin Wolf wrote:
> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>> Hi folks:
>>
>> We've captured a regression with floppy disk on recent qemu (and
>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>
>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>> Author: Richard Henderson<rth@twiddle.net>
>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>
>>       fdc: Convert to isa_register_portio_list
>>
>>       Signed-off-by: Richard Henderson<rth@twiddle.net>
>>       Signed-off-by: Avi Kivity<avi@redhat.com>
>>
>> Since this commit, the guest doesn't see a floppy disk attached to it
>> anymore, blocking kvm autotest ability to install windows guests
>> automatically. This is a big deal for kvm autotest (ruins our automated
>> regression jobs), so please take a look at it.
> Can you please try again with the latest block branch? I think there is
> a patch queued that will fix it.
>
> Kevin

Kevin,

The behaviour of the latest block branch is indeed different, but not 
much better.

In my quick manual test, booting via a FreeDOS floppy image:

* latest master: does not seem to read the floppy at all
* latest block: reads the floppy only to the point that 'FreeDOS' is 
printed in the console

All other qemu/qemu-kvm versions tested (for example 0.15.0), 
successfully read and boot the same image.

CR.

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Lucas Meneghel Rodrigues]

On 10/26/2011 01:47 PM, Kevin Wolf wrote:
> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>> Hi folks:
>>
>> We've captured a regression with floppy disk on recent qemu (and
>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>
>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>> Author: Richard Henderson<rth@twiddle.net>
>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>
>>       fdc: Convert to isa_register_portio_list
>>
>>       Signed-off-by: Richard Henderson<rth@twiddle.net>
>>       Signed-off-by: Avi Kivity<avi@redhat.com>
>>
>> Since this commit, the guest doesn't see a floppy disk attached to it
>> anymore, blocking kvm autotest ability to install windows guests
>> automatically. This is a big deal for kvm autotest (ruins our automated
>> regression jobs), so please take a look at it.
>
> Can you please try again with the latest block branch? I think there is
> a patch queued that will fix it.

Kevin, I did try with HEAD of your repo:

git://repo.or.cz/qemu/kevin.git

[lmr@freedom qemu-kwolf]$ git branch -r
   origin/HEAD -> origin/master
   origin/blkqueue
   origin/blkqueue-v1
   origin/block
   origin/coroutine
   origin/coroutine-block
   origin/coroutine-devel
   origin/devel
   origin/ehci
   origin/for-anthony
   origin/for-stable-0.14
   origin/inplace-conversion
   origin/master

With this repo, master branch, the problem persists. With the block 
branch, the problem persists.

Now, with the blkqueue branch the problem is resolved. Cleber had the 
same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.

Oh, you might want to check the blkqueue branch, it does have quite a 
bunch of set but unused variables, which will cause compilation errors 
unless --disable-werror is passed to the configure script.

Please merge the fixes with qemu master as soon as you can, we are 
probably leave windows installs from the upstream daily jobs until the 
fixes get to master.

Thanks,

Lucas

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Stefan Hajnoczi]

On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote:
> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
> >Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
> >>Hi folks:
> >>
> >>We've captured a regression with floppy disk on recent qemu (and
> >>qemu-kvm, after a code merge). We bisected it to be caused by:
> >>
> >>commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
> >>Author: Richard Henderson<rth@twiddle.net>
> >>Date:   Mon Aug 15 15:08:45 2011 -0700
> >>
> >>      fdc: Convert to isa_register_portio_list
> >>
> >>      Signed-off-by: Richard Henderson<rth@twiddle.net>
> >>      Signed-off-by: Avi Kivity<avi@redhat.com>
> >>
> >>Since this commit, the guest doesn't see a floppy disk attached to it
> >>anymore, blocking kvm autotest ability to install windows guests
> >>automatically. This is a big deal for kvm autotest (ruins our automated
> >>regression jobs), so please take a look at it.
> >
> >Can you please try again with the latest block branch? I think there is
> >a patch queued that will fix it.
> 
> Kevin, I did try with HEAD of your repo:
> 
> git://repo.or.cz/qemu/kevin.git
> 
> [lmr@freedom qemu-kwolf]$ git branch -r
>   origin/HEAD -> origin/master
>   origin/blkqueue
>   origin/blkqueue-v1
>   origin/block
>   origin/coroutine
>   origin/coroutine-block
>   origin/coroutine-devel
>   origin/devel
>   origin/ehci
>   origin/for-anthony
>   origin/for-stable-0.14
>   origin/inplace-conversion
>   origin/master
> 
> With this repo, master branch, the problem persists. With the block
> branch, the problem persists.
> 
> Now, with the blkqueue branch the problem is resolved. Cleber had
> the same results booting a FreeDOS floppy. So the fix is indeed in
> blkqueue.
> 
> Oh, you might want to check the blkqueue branch, it does have quite
> a bunch of set but unused variables, which will cause compilation
> errors unless --disable-werror is passed to the configure script.

I think blkqueue is an older development branch of the "block queue"
feature that Kevin was working on.  It is not Kevin's block tree (see
his "block" branch).

Stefan

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Lucas Meneghel Rodrigues]

On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote:
>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>> Hi folks:
>>>>
>>>> We've captured a regression with floppy disk on recent qemu (and
>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>
>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>> Author: Richard Henderson<rth@twiddle.net>
>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>
>>>>       fdc: Convert to isa_register_portio_list
>>>>
>>>>       Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>       Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>
>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>> anymore, blocking kvm autotest ability to install windows guests
>>>> automatically. This is a big deal for kvm autotest (ruins our automated
>>>> regression jobs), so please take a look at it.
>>>
>>> Can you please try again with the latest block branch? I think there is
>>> a patch queued that will fix it.
>>
>> Kevin, I did try with HEAD of your repo:
>>
>> git://repo.or.cz/qemu/kevin.git
>>
>> [lmr@freedom qemu-kwolf]$ git branch -r
>>    origin/HEAD ->  origin/master
>>    origin/blkqueue
>>    origin/blkqueue-v1
>>    origin/block
>>    origin/coroutine
>>    origin/coroutine-block
>>    origin/coroutine-devel
>>    origin/devel
>>    origin/ehci
>>    origin/for-anthony
>>    origin/for-stable-0.14
>>    origin/inplace-conversion
>>    origin/master
>>
>> With this repo, master branch, the problem persists. With the block
>> branch, the problem persists.
>>
>> Now, with the blkqueue branch the problem is resolved. Cleber had
>> the same results booting a FreeDOS floppy. So the fix is indeed in
>> blkqueue.
>>
>> Oh, you might want to check the blkqueue branch, it does have quite
>> a bunch of set but unused variables, which will cause compilation
>> errors unless --disable-werror is passed to the configure script.
>
> I think blkqueue is an older development branch of the "block queue"
> feature that Kevin was working on.  It is not Kevin's block tree (see
> his "block" branch).

So no, the block branch does not resolve the floppy access problem.

Well, considering the tests of the stable set I'm running against qemu 
right now, this is not the biggest of our problems... I'm verifying qemu 
is segfaulting on nearly every prolonged attempt of doing migration... 
I'm about to write an email about it.

Thanks Stefan!

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Zhi Yong Wu]

On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
<lmr@redhat.com> wrote:
> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
>>
>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote:
>>>
>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>>>
>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>>>
>>>>> Hi folks:
>>>>>
>>>>> We've captured a regression with floppy disk on recent qemu (and
>>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>>
>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>>> Author: Richard Henderson<rth@twiddle.net>
>>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>>
>>>>>      fdc: Convert to isa_register_portio_list
>>>>>
>>>>>      Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>>      Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>
>>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>>> anymore, blocking kvm autotest ability to install windows guests
>>>>> automatically. This is a big deal for kvm autotest (ruins our automated
>>>>> regression jobs), so please take a look at it.
>>>>
>>>> Can you please try again with the latest block branch? I think there is
>>>> a patch queued that will fix it.
>>>
>>> Kevin, I did try with HEAD of your repo:
>>>
>>> git://repo.or.cz/qemu/kevin.git
>>>
>>> [lmr@freedom qemu-kwolf]$ git branch -r
>>>   origin/HEAD ->  origin/master
>>>   origin/blkqueue
>>>   origin/blkqueue-v1
>>>   origin/block
>>>   origin/coroutine
>>>   origin/coroutine-block
>>>   origin/coroutine-devel
>>>   origin/devel
>>>   origin/ehci
>>>   origin/for-anthony
>>>   origin/for-stable-0.14
>>>   origin/inplace-conversion
>>>   origin/master
>>>
>>> With this repo, master branch, the problem persists. With the block
>>> branch, the problem persists.
>>>
>>> Now, with the blkqueue branch the problem is resolved. Cleber had
>>> the same results booting a FreeDOS floppy. So the fix is indeed in
>>> blkqueue.
>>>
>>> Oh, you might want to check the blkqueue branch, it does have quite
>>> a bunch of set but unused variables, which will cause compilation
>>> errors unless --disable-werror is passed to the configure script.
>>
>> I think blkqueue is an older development branch of the "block queue"
>> feature that Kevin was working on.  It is not Kevin's block tree (see
>> his "block" branch).
>
> So no, the block branch does not resolve the floppy access problem.
>
> Well, considering the tests of the stable set I'm running against qemu right
> now, this is not the biggest of our problems... I'm verifying qemu is
> segfaulting on nearly every prolonged attempt of doing migration... I'm
> about to write an email about it.
What is the OS of your guest? fedora16 or RHEL6? I would like recently
to use floppy device in guest.

>
> Thanks Stefan!
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Regards,

Zhi Yong Wu

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Lucas Meneghel Rodrigues]

On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote:
> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
> <lmr@redhat.com>  wrote:
>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
>>>
>>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote:
>>>>
>>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>>>>
>>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>>>>
>>>>>> Hi folks:
>>>>>>
>>>>>> We've captured a regression with floppy disk on recent qemu (and
>>>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>>>
>>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>>>> Author: Richard Henderson<rth@twiddle.net>
>>>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>>>
>>>>>>       fdc: Convert to isa_register_portio_list
>>>>>>
>>>>>>       Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>>>       Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>>
>>>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>>>> anymore, blocking kvm autotest ability to install windows guests
>>>>>> automatically. This is a big deal for kvm autotest (ruins our automated
>>>>>> regression jobs), so please take a look at it.
>>>>>
>>>>> Can you please try again with the latest block branch? I think there is
>>>>> a patch queued that will fix it.
>>>>
>>>> Kevin, I did try with HEAD of your repo:
>>>>
>>>> git://repo.or.cz/qemu/kevin.git
>>>>
>>>> [lmr@freedom qemu-kwolf]$ git branch -r
>>>>    origin/HEAD ->    origin/master
>>>>    origin/blkqueue
>>>>    origin/blkqueue-v1
>>>>    origin/block
>>>>    origin/coroutine
>>>>    origin/coroutine-block
>>>>    origin/coroutine-devel
>>>>    origin/devel
>>>>    origin/ehci
>>>>    origin/for-anthony
>>>>    origin/for-stable-0.14
>>>>    origin/inplace-conversion
>>>>    origin/master
>>>>
>>>> With this repo, master branch, the problem persists. With the block
>>>> branch, the problem persists.
>>>>
>>>> Now, with the blkqueue branch the problem is resolved. Cleber had
>>>> the same results booting a FreeDOS floppy. So the fix is indeed in
>>>> blkqueue.
>>>>
>>>> Oh, you might want to check the blkqueue branch, it does have quite
>>>> a bunch of set but unused variables, which will cause compilation
>>>> errors unless --disable-werror is passed to the configure script.
>>>
>>> I think blkqueue is an older development branch of the "block queue"
>>> feature that Kevin was working on.  It is not Kevin's block tree (see
>>> his "block" branch).
>>
>> So no, the block branch does not resolve the floppy access problem.
>>
>> Well, considering the tests of the stable set I'm running against qemu right
>> now, this is not the biggest of our problems... I'm verifying qemu is
>> segfaulting on nearly every prolonged attempt of doing migration... I'm
>> about to write an email about it.
> What is the OS of your guest? fedora16 or RHEL6? I would like recently
> to use floppy device in guest.

Fedora 15.

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Zhi Yong Wu]

On Fri, Oct 28, 2011 at 10:20 AM, Lucas Meneghel Rodrigues
<lmr@redhat.com> wrote:
> On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote:
>>
>> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
>> <lmr@redhat.com>  wrote:
>>>
>>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
>>>>
>>>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues
>>>> wrote:
>>>>>
>>>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>>>>>
>>>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>>>>>
>>>>>>> Hi folks:
>>>>>>>
>>>>>>> We've captured a regression with floppy disk on recent qemu (and
>>>>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>>>>
>>>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>>>>> Author: Richard Henderson<rth@twiddle.net>
>>>>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>>>>
>>>>>>>      fdc: Convert to isa_register_portio_list
>>>>>>>
>>>>>>>      Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>>>>      Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>>>
>>>>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>>>>> anymore, blocking kvm autotest ability to install windows guests
>>>>>>> automatically. This is a big deal for kvm autotest (ruins our
>>>>>>> automated
>>>>>>> regression jobs), so please take a look at it.
>>>>>>
>>>>>> Can you please try again with the latest block branch? I think there
>>>>>> is
>>>>>> a patch queued that will fix it.
>>>>>
>>>>> Kevin, I did try with HEAD of your repo:
>>>>>
>>>>> git://repo.or.cz/qemu/kevin.git
>>>>>
>>>>> [lmr@freedom qemu-kwolf]$ git branch -r
>>>>>   origin/HEAD ->    origin/master
>>>>>   origin/blkqueue
>>>>>   origin/blkqueue-v1
>>>>>   origin/block
>>>>>   origin/coroutine
>>>>>   origin/coroutine-block
>>>>>   origin/coroutine-devel
>>>>>   origin/devel
>>>>>   origin/ehci
>>>>>   origin/for-anthony
>>>>>   origin/for-stable-0.14
>>>>>   origin/inplace-conversion
>>>>>   origin/master
>>>>>
>>>>> With this repo, master branch, the problem persists. With the block
>>>>> branch, the problem persists.
>>>>>
>>>>> Now, with the blkqueue branch the problem is resolved. Cleber had
>>>>> the same results booting a FreeDOS floppy. So the fix is indeed in
>>>>> blkqueue.
>>>>>
>>>>> Oh, you might want to check the blkqueue branch, it does have quite
>>>>> a bunch of set but unused variables, which will cause compilation
>>>>> errors unless --disable-werror is passed to the configure script.
>>>>
>>>> I think blkqueue is an older development branch of the "block queue"
>>>> feature that Kevin was working on.  It is not Kevin's block tree (see
>>>> his "block" branch).
>>>
>>> So no, the block branch does not resolve the floppy access problem.
>>>
>>> Well, considering the tests of the stable set I'm running against qemu
>>> right
>>> now, this is not the biggest of our problems... I'm verifying qemu is
>>> segfaulting on nearly every prolonged attempt of doing migration... I'm
>>> about to write an email about it.
>>
>> What is the OS of your guest? fedora16 or RHEL6? I would like recently
>> to use floppy device in guest.
>
> Fedora 15.
Just i tried to use Fedora-15-x86_64-DVD.iso to install one guest, but  hang up.

My qemu.git/HEAD is 9f60639b848944200c3d33a89233d808de0b5a43.

While it can work when using ./Fedora-14-x86_64-DVD.iso.

>Regards,
>



-- 
Regards,

Zhi Yong Wu

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Zhi Yong Wu]

On Fri, Oct 28, 2011 at 6:24 PM, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
> On Fri, Oct 28, 2011 at 10:20 AM, Lucas Meneghel Rodrigues
> <lmr@redhat.com> wrote:
>> On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote:
>>>
>>> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
>>> <lmr@redhat.com>  wrote:
>>>>
>>>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
>>>>>
>>>>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues
>>>>> wrote:
>>>>>>
>>>>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>>>>>>
>>>>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>>>>>>
>>>>>>>> Hi folks:
>>>>>>>>
>>>>>>>> We've captured a regression with floppy disk on recent qemu (and
>>>>>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>>>>>
>>>>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>>>>>> Author: Richard Henderson<rth@twiddle.net>
>>>>>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>>>>>
>>>>>>>>      fdc: Convert to isa_register_portio_list
>>>>>>>>
>>>>>>>>      Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>>>>>      Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>>>>
>>>>>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>>>>>> anymore, blocking kvm autotest ability to install windows guests
>>>>>>>> automatically. This is a big deal for kvm autotest (ruins our
>>>>>>>> automated
>>>>>>>> regression jobs), so please take a look at it.
>>>>>>>
>>>>>>> Can you please try again with the latest block branch? I think there
>>>>>>> is
>>>>>>> a patch queued that will fix it.
>>>>>>
>>>>>> Kevin, I did try with HEAD of your repo:
>>>>>>
>>>>>> git://repo.or.cz/qemu/kevin.git
>>>>>>
>>>>>> [lmr@freedom qemu-kwolf]$ git branch -r
>>>>>>   origin/HEAD ->    origin/master
>>>>>>   origin/blkqueue
>>>>>>   origin/blkqueue-v1
>>>>>>   origin/block
>>>>>>   origin/coroutine
>>>>>>   origin/coroutine-block
>>>>>>   origin/coroutine-devel
>>>>>>   origin/devel
>>>>>>   origin/ehci
>>>>>>   origin/for-anthony
>>>>>>   origin/for-stable-0.14
>>>>>>   origin/inplace-conversion
>>>>>>   origin/master
>>>>>>
>>>>>> With this repo, master branch, the problem persists. With the block
>>>>>> branch, the problem persists.
>>>>>>
>>>>>> Now, with the blkqueue branch the problem is resolved. Cleber had
>>>>>> the same results booting a FreeDOS floppy. So the fix is indeed in
>>>>>> blkqueue.
>>>>>>
>>>>>> Oh, you might want to check the blkqueue branch, it does have quite
>>>>>> a bunch of set but unused variables, which will cause compilation
>>>>>> errors unless --disable-werror is passed to the configure script.
>>>>>
>>>>> I think blkqueue is an older development branch of the "block queue"
>>>>> feature that Kevin was working on.  It is not Kevin's block tree (see
>>>>> his "block" branch).
>>>>
>>>> So no, the block branch does not resolve the floppy access problem.
>>>>
>>>> Well, considering the tests of the stable set I'm running against qemu
>>>> right
>>>> now, this is not the biggest of our problems... I'm verifying qemu is
>>>> segfaulting on nearly every prolonged attempt of doing migration... I'm
>>>> about to write an email about it.
>>>
>>> What is the OS of your guest? fedora16 or RHEL6? I would like recently
>>> to use floppy device in guest.
>>
>> Fedora 15.
And on one host with OS Fedora 15, after floppy.ko is loaded, i have
not seen its device file /dev/fd0.

On one guest with RH6 or Fedora 14, it fails to load floppy.ko.


> Just i tried to use Fedora-15-x86_64-DVD.iso to install one guest, but  hang up.
>
> My qemu.git/HEAD is 9f60639b848944200c3d33a89233d808de0b5a43.
>
> While it can work when using ./Fedora-14-x86_64-DVD.iso.
>
>>Regards,
>>
>
>
>
> --
> Regards,
>
> Zhi Yong Wu
>



-- 
Regards,

Zhi Yong Wu

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Lucas Meneghel Rodrigues]

On 10/27/2011 11:17 PM, Zhi Yong Wu wrote:
> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
> <lmr@redhat.com>  wrote:
>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
>>>
>>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote:
>>>>
>>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>>>>
>>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>>>>
>>>>>> Hi folks:
>>>>>>
>>>>>> We've captured a regression with floppy disk on recent qemu (and
>>>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>>>
>>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>>>> Author: Richard Henderson<rth@twiddle.net>
>>>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>>>
>>>>>>       fdc: Convert to isa_register_portio_list
>>>>>>
>>>>>>       Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>>>       Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>>
>>>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>>>> anymore, blocking kvm autotest ability to install windows guests
>>>>>> automatically. This is a big deal for kvm autotest (ruins our automated
>>>>>> regression jobs), so please take a look at it.
>>>>>
>>>>> Can you please try again with the latest block branch? I think there is
>>>>> a patch queued that will fix it.
>>>>
>>>> Kevin, I did try with HEAD of your repo:
>>>>
>>>> git://repo.or.cz/qemu/kevin.git
>>>>
>>>> [lmr@freedom qemu-kwolf]$ git branch -r
>>>>    origin/HEAD ->    origin/master
>>>>    origin/blkqueue
>>>>    origin/blkqueue-v1
>>>>    origin/block
>>>>    origin/coroutine
>>>>    origin/coroutine-block
>>>>    origin/coroutine-devel
>>>>    origin/devel
>>>>    origin/ehci
>>>>    origin/for-anthony
>>>>    origin/for-stable-0.14
>>>>    origin/inplace-conversion
>>>>    origin/master
>>>>
>>>> With this repo, master branch, the problem persists. With the block
>>>> branch, the problem persists.
>>>>
>>>> Now, with the blkqueue branch the problem is resolved. Cleber had
>>>> the same results booting a FreeDOS floppy. So the fix is indeed in
>>>> blkqueue.
>>>>
>>>> Oh, you might want to check the blkqueue branch, it does have quite
>>>> a bunch of set but unused variables, which will cause compilation
>>>> errors unless --disable-werror is passed to the configure script.
>>>
>>> I think blkqueue is an older development branch of the "block queue"
>>> feature that Kevin was working on.  It is not Kevin's block tree (see
>>> his "block" branch).
>>
>> So no, the block branch does not resolve the floppy access problem.
>>
>> Well, considering the tests of the stable set I'm running against qemu right
>> now, this is not the biggest of our problems... I'm verifying qemu is
>> segfaulting on nearly every prolonged attempt of doing migration... I'm
>> about to write an email about it.
> What is the OS of your guest? fedora16 or RHEL6? I would like recently
> to use floppy device in guest.

Ok, correcting my answer, it was Windows 7 SP1. For some reason, I read 
'host' instead of guest. I had a long day when I wrote the 1st reply.

It's been a while that we've verified that the linux floppy driver is 
quite unstable. In general linux + floppy devices on a guest tends to 
crash the guest kernel, and that's why in kvm autotest we moved from 
floppy devices to cdroms to hold the kickstart file. The fact you 
managed to get things working under F14 means you are lucky, and that 
particular floppy driver bug does not happen under F14's kernel. We 
never had such a kernel crash problem with any of the Windows's kernels.

So if I were you, I would *not* use a floppy with a linux guest. Well, 
unless you want to debug the floppy driver bug and fix this on upstream 
linux once for all, so future versions of linux won't have this problem.

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Gleb Natapov]

On Fri, Oct 28, 2011 at 09:46:33AM -0200, Lucas Meneghel Rodrigues wrote:
> On 10/27/2011 11:17 PM, Zhi Yong Wu wrote:
> >On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
> ><lmr@redhat.com>  wrote:
> >>On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
> >>>
> >>>On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote:
> >>>>
> >>>>On 10/26/2011 01:47 PM, Kevin Wolf wrote:
> >>>>>
> >>>>>Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
> >>>>>>
> >>>>>>Hi folks:
> >>>>>>
> >>>>>>We've captured a regression with floppy disk on recent qemu (and
> >>>>>>qemu-kvm, after a code merge). We bisected it to be caused by:
> >>>>>>
> >>>>>>commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
> >>>>>>Author: Richard Henderson<rth@twiddle.net>
> >>>>>>Date:   Mon Aug 15 15:08:45 2011 -0700
> >>>>>>
> >>>>>>      fdc: Convert to isa_register_portio_list
> >>>>>>
> >>>>>>      Signed-off-by: Richard Henderson<rth@twiddle.net>
> >>>>>>      Signed-off-by: Avi Kivity<avi@redhat.com>
> >>>>>>
> >>>>>>Since this commit, the guest doesn't see a floppy disk attached to it
> >>>>>>anymore, blocking kvm autotest ability to install windows guests
> >>>>>>automatically. This is a big deal for kvm autotest (ruins our automated
> >>>>>>regression jobs), so please take a look at it.
> >>>>>
> >>>>>Can you please try again with the latest block branch? I think there is
> >>>>>a patch queued that will fix it.
> >>>>
> >>>>Kevin, I did try with HEAD of your repo:
> >>>>
> >>>>git://repo.or.cz/qemu/kevin.git
> >>>>
> >>>>[lmr@freedom qemu-kwolf]$ git branch -r
> >>>>   origin/HEAD ->    origin/master
> >>>>   origin/blkqueue
> >>>>   origin/blkqueue-v1
> >>>>   origin/block
> >>>>   origin/coroutine
> >>>>   origin/coroutine-block
> >>>>   origin/coroutine-devel
> >>>>   origin/devel
> >>>>   origin/ehci
> >>>>   origin/for-anthony
> >>>>   origin/for-stable-0.14
> >>>>   origin/inplace-conversion
> >>>>   origin/master
> >>>>
> >>>>With this repo, master branch, the problem persists. With the block
> >>>>branch, the problem persists.
> >>>>
> >>>>Now, with the blkqueue branch the problem is resolved. Cleber had
> >>>>the same results booting a FreeDOS floppy. So the fix is indeed in
> >>>>blkqueue.
> >>>>
> >>>>Oh, you might want to check the blkqueue branch, it does have quite
> >>>>a bunch of set but unused variables, which will cause compilation
> >>>>errors unless --disable-werror is passed to the configure script.
> >>>
> >>>I think blkqueue is an older development branch of the "block queue"
> >>>feature that Kevin was working on.  It is not Kevin's block tree (see
> >>>his "block" branch).
> >>
> >>So no, the block branch does not resolve the floppy access problem.
> >>
> >>Well, considering the tests of the stable set I'm running against qemu right
> >>now, this is not the biggest of our problems... I'm verifying qemu is
> >>segfaulting on nearly every prolonged attempt of doing migration... I'm
> >>about to write an email about it.
> >What is the OS of your guest? fedora16 or RHEL6? I would like recently
> >to use floppy device in guest.
> 
> Ok, correcting my answer, it was Windows 7 SP1. For some reason, I
> read 'host' instead of guest. I had a long day when I wrote the 1st
> reply.
> 
> It's been a while that we've verified that the linux floppy driver
> is quite unstable. In general linux + floppy devices on a guest
> tends to crash the guest kernel, and that's why in kvm autotest we
> moved from floppy devices to cdroms to hold the kickstart file. The
> fact you managed to get things working under F14 means you are
> lucky, and that particular floppy driver bug does not happen under
> F14's kernel. We never had such a kernel crash problem with any of
> the Windows's kernels.
> 
> So if I were you, I would *not* use a floppy with a linux guest.
> Well, unless you want to debug the floppy driver bug and fix this on
> upstream linux once for all, so future versions of linux won't have
> this problem.
AFAIK the problem exists only on smp guest.

--
			Gleb.

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Zhi Yong Wu]

On Fri, Oct 28, 2011 at 7:46 PM, Lucas Meneghel Rodrigues
<lmr@redhat.com> wrote:
> On 10/27/2011 11:17 PM, Zhi Yong Wu wrote:
>>
>> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues
>> <lmr@redhat.com>  wrote:
>>>
>>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote:
>>>>
>>>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues
>>>> wrote:
>>>>>
>>>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote:
>>>>>>
>>>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
>>>>>>>
>>>>>>> Hi folks:
>>>>>>>
>>>>>>> We've captured a regression with floppy disk on recent qemu (and
>>>>>>> qemu-kvm, after a code merge). We bisected it to be caused by:
>>>>>>>
>>>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>>>>>>> Author: Richard Henderson<rth@twiddle.net>
>>>>>>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>>>>>>
>>>>>>>      fdc: Convert to isa_register_portio_list
>>>>>>>
>>>>>>>      Signed-off-by: Richard Henderson<rth@twiddle.net>
>>>>>>>      Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>>>
>>>>>>> Since this commit, the guest doesn't see a floppy disk attached to it
>>>>>>> anymore, blocking kvm autotest ability to install windows guests
>>>>>>> automatically. This is a big deal for kvm autotest (ruins our
>>>>>>> automated
>>>>>>> regression jobs), so please take a look at it.
>>>>>>
>>>>>> Can you please try again with the latest block branch? I think there
>>>>>> is
>>>>>> a patch queued that will fix it.
>>>>>
>>>>> Kevin, I did try with HEAD of your repo:
>>>>>
>>>>> git://repo.or.cz/qemu/kevin.git
>>>>>
>>>>> [lmr@freedom qemu-kwolf]$ git branch -r
>>>>>   origin/HEAD ->    origin/master
>>>>>   origin/blkqueue
>>>>>   origin/blkqueue-v1
>>>>>   origin/block
>>>>>   origin/coroutine
>>>>>   origin/coroutine-block
>>>>>   origin/coroutine-devel
>>>>>   origin/devel
>>>>>   origin/ehci
>>>>>   origin/for-anthony
>>>>>   origin/for-stable-0.14
>>>>>   origin/inplace-conversion
>>>>>   origin/master
>>>>>
>>>>> With this repo, master branch, the problem persists. With the block
>>>>> branch, the problem persists.
>>>>>
>>>>> Now, with the blkqueue branch the problem is resolved. Cleber had
>>>>> the same results booting a FreeDOS floppy. So the fix is indeed in
>>>>> blkqueue.
>>>>>
>>>>> Oh, you might want to check the blkqueue branch, it does have quite
>>>>> a bunch of set but unused variables, which will cause compilation
>>>>> errors unless --disable-werror is passed to the configure script.
>>>>
>>>> I think blkqueue is an older development branch of the "block queue"
>>>> feature that Kevin was working on.  It is not Kevin's block tree (see
>>>> his "block" branch).
>>>
>>> So no, the block branch does not resolve the floppy access problem.
>>>
>>> Well, considering the tests of the stable set I'm running against qemu
>>> right
>>> now, this is not the biggest of our problems... I'm verifying qemu is
>>> segfaulting on nearly every prolonged attempt of doing migration... I'm
>>> about to write an email about it.
>>
>> What is the OS of your guest? fedora16 or RHEL6? I would like recently
>> to use floppy device in guest.
>
> Ok, correcting my answer, it was Windows 7 SP1. For some reason, I read
> 'host' instead of guest. I had a long day when I wrote the 1st reply.
>
> It's been a while that we've verified that the linux floppy driver is quite
> unstable. In general linux + floppy devices on a guest tends to crash the
> guest kernel, and that's why in kvm autotest we moved from floppy devices to
> cdroms to hold the kickstart file. The fact you managed to get things
> working under F14 means you are lucky, and that particular floppy driver bug
> does not happen under F14's kernel. We never had such a kernel crash problem
> with any of the Windows's kernels.
>
> So if I were you, I would *not* use a floppy with a linux guest. Well,
> unless you want to debug the floppy driver bug and fix this on upstream
> linux once for all, so future versions of linux won't have this problem.
I need to do some works for fdc, etc. So i have to use it in one
linux guest. anyway, thanks.

>



-- 
Regards,

Zhi Yong Wu

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Zhi Yong Wu]

On Wed, Oct 26, 2011 at 10:41 PM, Lucas Meneghel Rodrigues
<lmr@redhat.com> wrote:
> Hi folks:
>
> We've captured a regression with floppy disk on recent qemu (and qemu-kvm,
> after a code merge). We bisected it to be caused by:
>
> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
> Author: Richard Henderson <rth@twiddle.net>
> Date:   Mon Aug 15 15:08:45 2011 -0700
>
>    fdc: Convert to isa_register_portio_list
>
>    Signed-off-by: Richard Henderson <rth@twiddle.net>
>    Signed-off-by: Avi Kivity <avi@redhat.com>
>
> Since this commit, the guest doesn't see a floppy disk attached to it
> anymore, blocking kvm autotest ability to install windows guests
> automatically. This is a big deal for kvm autotest (ruins our automated
> regression jobs), so please take a look at it.
Just i tried the latest qemu.git upstream, it can work for floppy now.
I can see the floppy drive on guest and the file in it saved by me.

My qemu.git/HEAD is

commit e072ea2fd8fdceef64159b9596d3c15ce01bea91
Author: Anthony Liguori <aliguori@us.ibm.com>
Date:   Tue Nov 1 19:37:01 2011 -0500

    Bump version to 1.0-rc0

    Look out 1.0, here we come!

    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>


>
> Cheers,
>
> Lucas and Cleber
>
>



-- 
Regards,

Zhi Yong Wu

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

[Lucas Meneghel Rodrigues]

On 11/02/2011 05:48 AM, Zhi Yong Wu wrote:
> On Wed, Oct 26, 2011 at 10:41 PM, Lucas Meneghel Rodrigues
> <lmr@redhat.com>  wrote:
>> Hi folks:
>>
>> We've captured a regression with floppy disk on recent qemu (and qemu-kvm,
>> after a code merge). We bisected it to be caused by:
>>
>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
>> Author: Richard Henderson<rth@twiddle.net>
>> Date:   Mon Aug 15 15:08:45 2011 -0700
>>
>>     fdc: Convert to isa_register_portio_list
>>
>>     Signed-off-by: Richard Henderson<rth@twiddle.net>
>>     Signed-off-by: Avi Kivity<avi@redhat.com>
>>
>> Since this commit, the guest doesn't see a floppy disk attached to it
>> anymore, blocking kvm autotest ability to install windows guests
>> automatically. This is a big deal for kvm autotest (ruins our automated
>> regression jobs), so please take a look at it.
> Just i tried the latest qemu.git upstream, it can work for floppy now.
> I can see the floppy drive on guest and the file in it saved by me.
>
> My qemu.git/HEAD is
>
> commit e072ea2fd8fdceef64159b9596d3c15ce01bea91
> Author: Anthony Liguori<aliguori@us.ibm.com>
> Date:   Tue Nov 1 19:37:01 2011 -0500
>
>      Bump version to 1.0-rc0
>
>      Look out 1.0, here we come!
>
>      Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>

Ok, I have triggered some jobs and will look during the morning whether 
this is working for us as well.