From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/7] ide: Fix off-by-one error in array index check
Date: Thu, 27 Oct 2011 09:32:43 +0200 [thread overview]
Message-ID: <4EA9091B.1010906@redhat.com> (raw)
In-Reply-To: <1319632282-22725-5-git-send-email-kwolf@redhat.com>
On 10/26/2011 02:31 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
> ---
> hw/ide/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 280a117..29305d3 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -2039,7 +2039,7 @@ static int ide_drive_pio_post_load(void *opaque, int version_id)
> {
> IDEState *s = opaque;
>
> - if (s->end_transfer_fn_idx> ARRAY_SIZE(transfer_end_table)) {
> + if (s->end_transfer_fn_idx>= ARRAY_SIZE(transfer_end_table)) {
> return -EINVAL;
> }
> s->end_transfer_func = transfer_end_table[s->end_transfer_fn_idx];
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2011-10-27 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 12:31 [Qemu-devel] [PATCH 0/7] block: Collection of unrelated simple fixes Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 1/7] block: Remove dead code Kevin Wolf
2011-10-27 1:50 ` Robert Wang
2011-10-27 7:37 ` Stefan Hajnoczi
2011-10-27 8:23 ` Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 2/7] block: Fix bdrv_open use after free Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 3/7] qcow: Fix bdrv_write_compressed error handling Kevin Wolf
2011-10-27 7:33 ` Paolo Bonzini
2011-10-26 12:31 ` [Qemu-devel] [PATCH 4/7] ide: Fix off-by-one error in array index check Kevin Wolf
2011-10-27 7:32 ` Paolo Bonzini [this message]
2011-10-26 12:31 ` [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value Kevin Wolf
2011-10-26 13:21 ` Pavel Borzenkov
2011-10-26 13:50 ` Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 6/7] vmdk: Improve error handling Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 7/7] vmdk: Fix possible segfaults Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA9091B.1010906@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).