From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RJMK8-0008Q4-9X
	for qemu-devel@nongnu.org; Thu, 27 Oct 2011 05:32:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RJMK7-0006WI-30
	for qemu-devel@nongnu.org; Thu, 27 Oct 2011 05:32:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47509)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RJMK6-0006W7-PL
	for qemu-devel@nongnu.org; Thu, 27 Oct 2011 05:32:31 -0400
Message-ID: <4EA925E6.2080002@redhat.com>
Date: Thu, 27 Oct 2011 11:35:34 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1319633497-19923-1-git-send-email-ronniesahlberg@gmail.com>
	<1319633497-19923-2-git-send-email-ronniesahlberg@gmail.com>
	<20111027071446.GB32287@stefanha-thinkpad.localdomain>
In-Reply-To: <20111027071446.GB32287@stefanha-thinkpad.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Documentation: add new section for device
 URL syntax for special files and describe the iSCSI URL with examples
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>

Am 27.10.2011 09:14, schrieb Stefan Hajnoczi:
> On Wed, Oct 26, 2011 at 11:51:37PM +1100, Ronnie Sahlberg wrote:
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> ---
>>  qemu-options.hx |   42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 42 insertions(+), 0 deletions(-)
> 
> Good idea, thanks for adding documentation.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Breaks the build. I'll amend the commit with the following changes:

diff --git a/qemu-options.hx b/qemu-options.hx
index 7c434f8..f967fb9 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1719,6 +1719,7 @@ Connect to a spice virtual machine channel, such
as vdiport.
 @end table
 ETEXI

+STEXI
 DEFHEADING()

 DEFHEADING(Device URL Syntax:)
@@ -1727,7 +1728,6 @@ In addition to using normal file images for the
emulated storage devices,
 QEMU can also use networked resources such as iSCSI devices. These are
 specified using a special URL syntax.

-STEXI
 @table @option
 @item iSCSI
 iSCSI support allows QEMU to access iSCSI resources directly and use as
@@ -1744,7 +1744,7 @@ qemu -cdrom
iscsi://192.0.2.1/iqn.2001-04.com.example/2 \

 Example (CHAP username/password via URL):
 @example
-qemu --drive file=iscsi://user%password@192.0.2.1/iqn.2001-04.com.example/1
+qemu --drive
file=iscsi://user%password@@192.0.2.1/iqn.2001-04.com.example/1
 @end example

 Example (CHAP username/password via environment variables):