From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJPAl-000277-FV for qemu-devel@nongnu.org; Thu, 27 Oct 2011 08:35:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJPAj-0001zO-UD for qemu-devel@nongnu.org; Thu, 27 Oct 2011 08:35:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJPAj-0001yS-9i for qemu-devel@nongnu.org; Thu, 27 Oct 2011 08:35:01 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9RCZ0Ds029514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Oct 2011 08:35:00 -0400 Message-ID: <4EA950AE.6050102@redhat.com> Date: Thu, 27 Oct 2011 14:38:06 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1317798728-28938-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 27.10.2011 13:46, schrieb Paolo Bonzini: > On 10/05/2011 09:12 AM, Paolo Bonzini wrote: >> It occurred to me that, if there's one thing vvfat ought to be good >> at, it is creating disk images with qemu-img convert (a driver disk >> in my case). >> >> It turns out the use case is really broken. qemu-img doesn't >> complete at all, the resulting images often do not pass fsck, >> and it's impossible to create a 1.44 MB disk image. This >> series fixes all of the small problems I found. >> >> Coding standard in this file is such a pain that I hardly bothered >> about it. >> >> >> Paolo Bonzini (6): >> vvfat: fix out of bounds array_get usage >> vvfat: do not fail if the disk has spare sectors >> vvfat: need to use first_sectors_number to distinguish fdd/hdd >> vvfat: unify and correct computation of sector count >> vvfat: do not hardcode sector counts in error message >> vvfat: reorganize computation of disk geometry >> >> block/vvfat.c | 50 ++++++++++++++++++++++++-------------------------- >> 3 files changed, 26 insertions(+), 28 deletions(-) >> > > ping? Looked at it a week or two ago, didn't immediately understand the first patch and decided that there's more important stuff for 1.0... Not sure what to do with it. The subject clearly says "fixes", so it should qualify for 1.0, but someone must review it. Kevin