From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJQ3g-0007ts-6H for qemu-devel@nongnu.org; Thu, 27 Oct 2011 09:31:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJQ3c-0005Up-5W for qemu-devel@nongnu.org; Thu, 27 Oct 2011 09:31:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJQ3b-0005Ul-SC for qemu-devel@nongnu.org; Thu, 27 Oct 2011 09:31:44 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9RDVgoW026813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Oct 2011 09:31:43 -0400 Message-ID: <4EA95DF8.90800@redhat.com> Date: Thu, 27 Oct 2011 15:34:48 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1317798728-28938-1-git-send-email-pbonzini@redhat.com> <4EA950AE.6050102@redhat.com> <4EA9582F.20700@redhat.com> In-Reply-To: <4EA9582F.20700@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 27.10.2011 15:10, schrieb Paolo Bonzini: > On 10/27/2011 02:38 PM, Kevin Wolf wrote: >> Am 27.10.2011 13:46, schrieb Paolo Bonzini: >>> On 10/05/2011 09:12 AM, Paolo Bonzini wrote: >>>> It occurred to me that, if there's one thing vvfat ought to be good >>>> at, it is creating disk images with qemu-img convert (a driver disk >>>> in my case). >>>> >>>> It turns out the use case is really broken. qemu-img doesn't >>>> complete at all, the resulting images often do not pass fsck, >>>> and it's impossible to create a 1.44 MB disk image. This >>>> series fixes all of the small problems I found. >>>> >>>> Coding standard in this file is such a pain that I hardly bothered >>>> about it. >>>> >>>> >>>> Paolo Bonzini (6): >>>> vvfat: fix out of bounds array_get usage >>>> vvfat: do not fail if the disk has spare sectors the >>>> vvfat: need to use first_sectors_number to distinguish fdd/hdd >>>> vvfat: unify and correct computation of sector count >>>> vvfat: do not hardcode sector counts in error message >>>> vvfat: reorganize computation of disk geometry >>>> >>>> block/vvfat.c | 50 ++++++++++++++++++++++++-------------------------- >>>> 3 files changed, 26 insertions(+), 28 deletions(-) >>>> >>> >>> ping? >> >> Looked at it a week or two ago, didn't immediately understand the first >> patch and decided that there's more important stuff for 1.0... > > Yeah. It can probably go in during the freeze. > > Regarding the first patch, we simply fail this assert: > > static inline void* array_get(array_t* array,unsigned int index) { > assert(index < array->next); > return array->pointer + index * array->item_size; > } > > so you need to first set s->directory.next like array_get_next does. So is this combination of array_ensure_allocated(), setting s->directory.next and memset() basically an open-coded array_set_size() that initialises new elements with zeros? Kevin