From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RJRbk-0002gl-KM
	for qemu-devel@nongnu.org; Thu, 27 Oct 2011 11:11:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RJRbe-0002gB-VB
	for qemu-devel@nongnu.org; Thu, 27 Oct 2011 11:11:04 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35298 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RJRbe-0002g6-QU
	for qemu-devel@nongnu.org; Thu, 27 Oct 2011 11:10:58 -0400
Message-ID: <4EA9747B.7010703@suse.de>
Date: Thu, 27 Oct 2011 17:10:51 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1319715472-16286-1-git-send-email-peter.maydell@linaro.org>
	<1319715472-16286-4-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1319715472-16286-4-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Make cpu_single_env thread-local
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, patches@linaro.org, "Dr. David Alan Gilbert" <david.gilbert@linaro.org>, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>

Am 27.10.2011 13:37, schrieb Peter Maydell:
> From: Paolo Bonzini <pbonzini@redhat.com>
>=20
> Make cpu_single_env thread-local. This fixes a regression
> in handling of multi-threaded programs in linux-user mode
> (bug 823902).
>=20
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> [Peter Maydell: rename tls_cpu_single_env to cpu_single_env]
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  cpu-all.h |    4 +++-
>  exec.c    |    2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/cpu-all.h b/cpu-all.h
> index 42a5fa0..5f47ab8 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -20,6 +20,7 @@
>  #define CPU_ALL_H
> =20
>  #include "qemu-common.h"
> +#include "qemu-tls.h"
>  #include "cpu-common.h"
> =20
>  /* some important defines:
[8<]

Is there a reason not to include this from qemu-common.h? To avoid
accidental use in unsuited cases? If so, add an explicit comment to
either qemu-common.h or Jan's comment in qemu-tls.h to avoid someone
doing such a cleanup/simplification patch?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg