From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJc43-0006WO-5T for qemu-devel@nongnu.org; Thu, 27 Oct 2011 22:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJc41-0006T5-N3 for qemu-devel@nongnu.org; Thu, 27 Oct 2011 22:20:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJc41-0006Sx-D3 for qemu-devel@nongnu.org; Thu, 27 Oct 2011 22:20:57 -0400 Message-ID: <4EAA1184.4000004@redhat.com> Date: Fri, 28 Oct 2011 00:20:52 -0200 From: Lucas Meneghel Rodrigues MIME-Version: 1.0 References: <4EA81C05.5090002@redhat.com> <4EA82BAA.10207@redhat.com> <4EA84115.9090707@redhat.com> <20111027071741.GC32287@stefanha-thinkpad.localdomain> <4EA9A9AA.9060208@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: Kevin Wolf , KVM mailing list , Stefan Hajnoczi , Marcelo Tosatti , QEMU devel , Avi Kivity , Cleber Rosa , Richard Henderson On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote: > On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues > wrote: >> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote: >>>> >>>> On 10/26/2011 01:47 PM, Kevin Wolf wrote: >>>>> >>>>> Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues: >>>>>> >>>>>> Hi folks: >>>>>> >>>>>> We've captured a regression with floppy disk on recent qemu (and >>>>>> qemu-kvm, after a code merge). We bisected it to be caused by: >>>>>> >>>>>> commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 >>>>>> Author: Richard Henderson >>>>>> Date: Mon Aug 15 15:08:45 2011 -0700 >>>>>> >>>>>> fdc: Convert to isa_register_portio_list >>>>>> >>>>>> Signed-off-by: Richard Henderson >>>>>> Signed-off-by: Avi Kivity >>>>>> >>>>>> Since this commit, the guest doesn't see a floppy disk attached to it >>>>>> anymore, blocking kvm autotest ability to install windows guests >>>>>> automatically. This is a big deal for kvm autotest (ruins our automated >>>>>> regression jobs), so please take a look at it. >>>>> >>>>> Can you please try again with the latest block branch? I think there is >>>>> a patch queued that will fix it. >>>> >>>> Kevin, I did try with HEAD of your repo: >>>> >>>> git://repo.or.cz/qemu/kevin.git >>>> >>>> [lmr@freedom qemu-kwolf]$ git branch -r >>>> origin/HEAD -> origin/master >>>> origin/blkqueue >>>> origin/blkqueue-v1 >>>> origin/block >>>> origin/coroutine >>>> origin/coroutine-block >>>> origin/coroutine-devel >>>> origin/devel >>>> origin/ehci >>>> origin/for-anthony >>>> origin/for-stable-0.14 >>>> origin/inplace-conversion >>>> origin/master >>>> >>>> With this repo, master branch, the problem persists. With the block >>>> branch, the problem persists. >>>> >>>> Now, with the blkqueue branch the problem is resolved. Cleber had >>>> the same results booting a FreeDOS floppy. So the fix is indeed in >>>> blkqueue. >>>> >>>> Oh, you might want to check the blkqueue branch, it does have quite >>>> a bunch of set but unused variables, which will cause compilation >>>> errors unless --disable-werror is passed to the configure script. >>> >>> I think blkqueue is an older development branch of the "block queue" >>> feature that Kevin was working on. It is not Kevin's block tree (see >>> his "block" branch). >> >> So no, the block branch does not resolve the floppy access problem. >> >> Well, considering the tests of the stable set I'm running against qemu right >> now, this is not the biggest of our problems... I'm verifying qemu is >> segfaulting on nearly every prolonged attempt of doing migration... I'm >> about to write an email about it. > What is the OS of your guest? fedora16 or RHEL6? I would like recently > to use floppy device in guest. Fedora 15.