From: Avi Kivity <avi@redhat.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions
Date: Sun, 30 Oct 2011 13:59:16 +0200 [thread overview]
Message-ID: <4EAD3C14.7000905@redhat.com> (raw)
In-Reply-To: <1319640996-26537-1-git-send-email-benoit.canet@gmail.com>
On 10/26/2011 04:56 PM, Benoît Canet wrote:
> Convert most of pxa2xx periferal to memory API.
>
> pxa2xx_dmai.c was intact appart because it use
> cpu_physical_memory_read/write internal and seems special.
>
This patchset adds a lot of calls to get_system_memory(), which
undermines one of the purposes of the memory API - to avoid global
knowledge. Please make the various initialization functions accept a
MemoryRegion parameter, and use get_system_memory() in just one place
(the best place is the machine init callback).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-10-30 11:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 14:56 [Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 01/10] pxa2xx_gpio: convert to memory API Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 02/10] pxa2xx_pcmcia.c: convert common memory space " Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 03/10] pxa2xx_pcmcia.c: convert attribute " Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 04/10] pxa2xx_pcmcia.c: convert io " Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 05/10] pxa2xx_pcmcia.c: merge calls to get_system_memory() Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 06/10] pxa2xx_keypad: convert to memory API Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 07/10] pxa2xx_timer: " Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 08/10] pxa2xx_pic: " Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 09/10] pxa2xx_mmci: " Benoît Canet
2011-10-26 14:56 ` [Qemu-devel] [PATCH 10/10] pxa2xx_lcd: " Benoît Canet
2011-10-30 11:59 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAD3C14.7000905@redhat.com \
--to=avi@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).