From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKU2t-00081P-LA for qemu-devel@nongnu.org; Sun, 30 Oct 2011 07:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKU2s-0006Ez-Cs for qemu-devel@nongnu.org; Sun, 30 Oct 2011 07:59:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKU2s-0006Em-5I for qemu-devel@nongnu.org; Sun, 30 Oct 2011 07:59:22 -0400 Message-ID: <4EAD3C14.7000905@redhat.com> Date: Sun, 30 Oct 2011 13:59:16 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1319640996-26537-1-git-send-email-benoit.canet@gmail.com> In-Reply-To: <1319640996-26537-1-git-send-email-benoit.canet@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/10] pxa2xx: memory API conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 10/26/2011 04:56 PM, Beno=C3=AEt Canet wrote: > Convert most of pxa2xx periferal to memory API. > > pxa2xx_dmai.c was intact appart because it use > cpu_physical_memory_read/write internal and seems special. > This patchset adds a lot of calls to get_system_memory(), which undermines one of the purposes of the memory API - to avoid global knowledge. Please make the various initialization functions accept a MemoryRegion parameter, and use get_system_memory() in just one place (the best place is the machine init callback). --=20 error compiling committee.c: too many arguments to function