From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKmtc-0001tz-9h for qemu-devel@nongnu.org; Mon, 31 Oct 2011 04:07:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKmtb-0002eo-8E for qemu-devel@nongnu.org; Mon, 31 Oct 2011 04:07:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKmta-0002ea-UR for qemu-devel@nongnu.org; Mon, 31 Oct 2011 04:07:03 -0400 Message-ID: <4EAE57DF.9080602@redhat.com> Date: Mon, 31 Oct 2011 09:10:07 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1320030109-20476-1-git-send-email-wuzhy@linux.vnet.ibm.com> In-Reply-To: <1320030109-20476-1-git-send-email-wuzhy@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 31.10.2011 04:01, schrieb Zhi Yong Wu: > It is better to use qiov.size in qed-table.c to get nb_sectors than iov.iov_len. > > Signed-off-by: Zhi Yong Wu The commit message should probably say why it's better. Not saying otherwise, but I can't see the different at the first sight. Kevin