qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: "Daniel P. Berrange" <berrange@redhat.com>,
	Juan Pineda <juan@logician.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Problem under OSX Lion: GThread-ERROR **: GThread system may only be initialized once
Date: Mon, 31 Oct 2011 17:40:02 +0100	[thread overview]
Message-ID: <4EAECF62.2050805@web.de> (raw)
In-Reply-To: <20111031163604.GH27570@redhat.com>

Am 31.10.2011 17:36, schrieb Daniel P. Berrange:
> On Mon, Oct 31, 2011 at 09:25:26AM -0700, Juan Pineda wrote:
>> The current Qemu master branch crashes under OSX with a GThread error.
>> Commenting out vlc.c line 2188 (call to g_thread_init) allows it to run
>> successfully.
> 
> As a general rule all calls to 'g_thread_init(NULL)' should be protected
> by a conditional thus:
> 
>         if (!g_thread_supported())
>             g_thread_init(NULL);
> 
> Even though QEMU calls g_thread_init() very early in main(), there is
> always the possibility that some library QEMU links to, has got an ELF
> initializer, triggering before main(), which calls g_thread_init().

Thanks to both of you! I checked: vl.c is the only use without such
condition. So it seems this regression was introduced through
coroutine-gthread.c and is not specific to Darwin. I'll post a patch
shortly.

Andreas

      reply	other threads:[~2011-10-31 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18  1:22 [Qemu-devel] Patch for ui/cocoa.m Juan Pineda
2011-10-18  9:11 ` Andreas Färber
2011-10-18 14:35   ` Juan Pineda
2011-10-30 22:45     ` Andreas Färber
2011-10-31 15:32       ` Juan Pineda
2011-10-31 16:25         ` [Qemu-devel] Problem under OSX Lion: GThread-ERROR **: GThread system may only be initialized once Juan Pineda
2011-10-31 16:36           ` Daniel P. Berrange
2011-10-31 16:40             ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAECF62.2050805@web.de \
    --to=andreas.faerber@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=berrange@redhat.com \
    --cc=juan@logician.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).