From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 01/13] remove unused function
Date: Mon, 31 Oct 2011 13:10:39 -0500 [thread overview]
Message-ID: <4EAEE49F.5050006@codemonkey.ws> (raw)
In-Reply-To: <1319214405-20388-2-git-send-email-pbonzini@redhat.com>
Are you planning on spinning a v4 with TeLeMan's suggestions by tomorrow?
Regards,
Anthony Liguori
On 10/21/2011 11:26 AM, Paolo Bonzini wrote:
> Reviewed-by: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> hw/mac_dbdma.c | 5 -----
> hw/mac_dbdma.h | 1 -
> 2 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c
> index 5affdd1..1791ec1 100644
> --- a/hw/mac_dbdma.c
> +++ b/hw/mac_dbdma.c
> @@ -661,11 +661,6 @@ void DBDMA_register_channel(void *dbdma, int nchan, qemu_irq irq,
> ch->io.channel = ch;
> }
>
> -void DBDMA_schedule(void)
> -{
> - qemu_notify_event();
> -}
> -
> static void
> dbdma_control_write(DBDMA_channel *ch)
> {
> diff --git a/hw/mac_dbdma.h b/hw/mac_dbdma.h
> index 933e17c..6d1abe6 100644
> --- a/hw/mac_dbdma.h
> +++ b/hw/mac_dbdma.h
> @@ -41,5 +41,4 @@ struct DBDMA_io {
> void DBDMA_register_channel(void *dbdma, int nchan, qemu_irq irq,
> DBDMA_rw rw, DBDMA_flush flush,
> void *opaque);
> -void DBDMA_schedule(void);
> void* DBDMA_init (MemoryRegion **dbdma_mem);
next prev parent reply other threads:[~2011-10-31 18:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 16:26 [Qemu-devel] [PULL v3 00/13] allow tools to use the QEMU main loop Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 01/13] remove unused function Paolo Bonzini
2011-10-31 18:10 ` Anthony Liguori [this message]
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 02/13] qemu-timer: remove active_timers array Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer Paolo Bonzini
2011-10-31 7:23 ` TeLeMan
2011-10-31 10:05 ` Paolo Bonzini
2011-10-31 17:13 ` Stefan Weil
2011-11-02 12:54 ` Paolo Bonzini
2011-11-02 13:31 ` Stefan Weil
2011-11-02 13:37 ` Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 04/13] qemu-timer: more clock functions Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 05/13] qemu-timer: move icount to cpus.c Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 06/13] qemu-timer: do not refer to runstate_is_running() Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 07/13] qemu-timer: use atexit for quit_timers Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 08/13] qemu-timer: move more stuff out of qemu-timer.c Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 09/13] qemu-timer: do not use RunState change handlers Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 10/13] main-loop: create main-loop.h Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 11/13] main-loop: create main-loop.c Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 12/13] Revert to a hand-made select loop Paolo Bonzini
2011-10-21 16:26 ` [Qemu-devel] [PATCH v3 13/13] simplify main loop functions Paolo Bonzini
2011-10-24 16:19 ` [Qemu-devel] [PULL v3 00/13] allow tools to use the QEMU main loop Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAEE49F.5050006@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).