From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53725)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RKwJp-0007Dk-6A
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 14:10:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RKwJo-0005zO-7l
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 14:10:45 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:61524)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RKwJo-0005zH-5C
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 14:10:44 -0400
Received: by ywb3 with SMTP id 3so7707258ywb.4
	for <qemu-devel@nongnu.org>; Mon, 31 Oct 2011 11:10:43 -0700 (PDT)
Message-ID: <4EAEE49F.5050006@codemonkey.ws>
Date: Mon, 31 Oct 2011 13:10:39 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1319214405-20388-1-git-send-email-pbonzini@redhat.com>
	<1319214405-20388-2-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1319214405-20388-2-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 01/13] remove unused function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Are you planning on spinning a v4 with TeLeMan's suggestions by tomorrow?

Regards,

Anthony Liguori

On 10/21/2011 11:26 AM, Paolo Bonzini wrote:
> Reviewed-by: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   hw/mac_dbdma.c |    5 -----
>   hw/mac_dbdma.h |    1 -
>   2 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/hw/mac_dbdma.c b/hw/mac_dbdma.c
> index 5affdd1..1791ec1 100644
> --- a/hw/mac_dbdma.c
> +++ b/hw/mac_dbdma.c
> @@ -661,11 +661,6 @@ void DBDMA_register_channel(void *dbdma, int nchan, qemu_irq irq,
>       ch->io.channel = ch;
>   }
>
> -void DBDMA_schedule(void)
> -{
> -    qemu_notify_event();
> -}
> -
>   static void
>   dbdma_control_write(DBDMA_channel *ch)
>   {
> diff --git a/hw/mac_dbdma.h b/hw/mac_dbdma.h
> index 933e17c..6d1abe6 100644
> --- a/hw/mac_dbdma.h
> +++ b/hw/mac_dbdma.h
> @@ -41,5 +41,4 @@ struct DBDMA_io {
>   void DBDMA_register_channel(void *dbdma, int nchan, qemu_irq irq,
>                               DBDMA_rw rw, DBDMA_flush flush,
>                               void *opaque);
> -void DBDMA_schedule(void);
>   void* DBDMA_init (MemoryRegion **dbdma_mem);