From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKwMr-0008NN-34 for qemu-devel@nongnu.org; Mon, 31 Oct 2011 14:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKwMp-0006MJ-On for qemu-devel@nongnu.org; Mon, 31 Oct 2011 14:13:53 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:54389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKwMp-0006ME-IR for qemu-devel@nongnu.org; Mon, 31 Oct 2011 14:13:51 -0400 Received: by gya6 with SMTP id 6so2526967gya.4 for ; Mon, 31 Oct 2011 11:13:51 -0700 (PDT) Message-ID: <4EAEE55C.7070400@redhat.com> Date: Mon, 31 Oct 2011 13:13:48 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1319976446-12602-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1319976446-12602-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: valgrind-developers@lists.sourceforge.net, qemu-devel@nongnu.org, Avi Kivity On 10/30/2011 07:07 AM, Stefan Weil wrote: > Valgrind is a tool which can automatically detect many kinds of bugs. > > Running QEMU on Valgrind with x86_64 hosts was not possible because > Valgrind aborts when memalign is called with an alignment larger than > 1 MiB. QEMU normally uses 2 MiB on Linux x86_64. > > Now the alignment is reduced to the page size when QEMU is running on > Valgrind. > > valgrind.h is a copy from Valgrind svn trunk r12226 with trailing > whitespace stripped but otherwise unmodified, so it still raises lots > of errors when checked with scripts/checkpatch.pl. > > It is included here to avoid a dependency on Valgrind. > > Signed-off-by: Stefan Weil How about we just fix valgrind? Regards, Anthony Liguori