From: "Andreas Färber" <andreas.faerber@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Pineda <juan@logician.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin
Date: Mon, 31 Oct 2011 20:17:58 +0100 [thread overview]
Message-ID: <4EAEF466.8050105@web.de> (raw)
In-Reply-To: <CAFEAcA_F6D7+piuuH3=GqM_6C345+e__wRKPufevEHbJnVah+Q@mail.gmail.com>
Am 31.10.2011 20:42, schrieb Peter Maydell:
> On 31 October 2011 19:18, Andreas Färber <andreas.faerber@web.de> wrote:
>> --- a/fpu/softfloat.h
>> +++ b/fpu/softfloat.h
>> @@ -54,6 +54,9 @@ these four paragraphs for those parts of this code that are retained.
>> | to the same as `int'.
>> *----------------------------------------------------------------------------*/
>> typedef uint8_t flag;
>> +#ifdef __APPLE__
>> +#define uint16 qemu_uint16
>> +#endif
>> typedef uint8_t uint8;
>> typedef int8_t int8;
>> #ifndef _AIX
>
> I hate this, but I don't think I quite hate it enough to leave compilation
> on Macs broken in 1.0...
>
> Ideally we should just make a decision about whether we want option
> (1) or (2) from
> http://permalink.gmane.org/gmane.comp.emulators.qemu/115848
That's what "more general solution" refers to.
At this point in time though I'd much prefer to commit a non-intrusive
three-line quickfix (which we can easily remove later on) than no
solution at all or than to refactor lots of softfloat code.
Andreas
next prev parent reply other threads:[~2011-10-31 20:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 19:17 [Qemu-devel] [PATCH v2 0/4] Cocoa patches for 1.0 Andreas Färber
2011-10-31 19:17 ` [Qemu-devel] [PATCH v2 1/4] MAINTAINERS: Add Cocoa maintainer Andreas Färber
2011-10-31 19:18 ` [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin Andreas Färber
2011-10-31 19:42 ` Peter Maydell
2011-10-31 19:17 ` Andreas Färber [this message]
2011-11-01 8:09 ` Eric Sunshine
2011-11-01 16:37 ` Andreas Färber
2011-11-01 17:59 ` [Qemu-devel] [PATCH v3 " Andreas Färber
2011-11-01 18:01 ` Peter Maydell
2011-11-01 18:05 ` Andreas Färber
2011-11-01 18:55 ` Eric Sunshine
2011-11-01 19:11 ` Andreas Färber
2011-11-01 18:17 ` Andreas Färber
2011-11-01 18:47 ` [Qemu-devel] [PATCH v2 " Eric Sunshine
2011-11-01 18:52 ` Andreas Färber
2011-11-01 19:06 ` Eric Sunshine
2011-11-01 19:25 ` Andreas Färber
2011-11-01 19:37 ` Peter Maydell
2011-11-01 19:45 ` Eric Sunshine
2011-11-01 20:21 ` Andreas Färber
2011-11-01 19:25 ` Eric Sunshine
2011-11-01 19:32 ` Andreas Färber
2011-10-31 19:18 ` [Qemu-devel] [PATCH v2 3/4] vl.c: Guard against GThread double-initialization Andreas Färber
2011-10-31 19:18 ` [Qemu-devel] [PATCH v2 4/4] cocoa: Close sheet after image file selection Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAEF466.8050105@web.de \
--to=andreas.faerber@web.de \
--cc=juan@logician.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).