From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41995)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RKxO3-0005E4-E5
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:19:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RKxO1-0004JQ-8Y
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:19:10 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:60636)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RKxO1-0004JA-3I
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 15:19:09 -0400
Received: by ywb3 with SMTP id 3so7778688ywb.4
	for <qemu-devel@nongnu.org>; Mon, 31 Oct 2011 12:19:08 -0700 (PDT)
Message-ID: <4EAEF4A8.70604@codemonkey.ws>
Date: Mon, 31 Oct 2011 14:19:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1319976446-12602-1-git-send-email-sw@weilnetz.de>	<4EAEE55C.7070400@redhat.com>
	<4EAEF0FB.9030802@weilnetz.de>
In-Reply-To: <4EAEF0FB.9030802@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On 10/31/2011 02:03 PM, Stefan Weil wrote:
> Am 31.10.2011 19:13, schrieb Anthony Liguori:
>> On 10/30/2011 07:07 AM, Stefan Weil wrote:
>>> Valgrind is a tool which can automatically detect many kinds of bugs.
>>>
>>> Running QEMU on Valgrind with x86_64 hosts was not possible because
>>> Valgrind aborts when memalign is called with an alignment larger than
>>> 1 MiB. QEMU normally uses 2 MiB on Linux x86_64.
>>>
>>> Now the alignment is reduced to the page size when QEMU is running on
>>> Valgrind.
>>>
>>> valgrind.h is a copy from Valgrind svn trunk r12226 with trailing
>>> whitespace stripped but otherwise unmodified, so it still raises lots
>>> of errors when checked with scripts/checkpatch.pl.
>>>
>>> It is included here to avoid a dependency on Valgrind.
>>>
>>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>>
>> How about we just fix valgrind?
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> Do you think that Valgrind will be fixed before tests of QEMU 1.0 start?
> I don't, and I think that using Valgrind should be part of these tests!
>
> I'd add the patch now. As soon as Valgrind is fixed, it can be reverted.
> Or we add another patch with the Valgrind hack from libvirt.

I definitely don't want to pull in a valgrind header.  The LD_PRELOAD check 
seems a bit ugly but I'd rather carry that as an intermediate solution.

Regards,

Anthony Liguori

>
> Regards,
> Stefan Weil
>
>