From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKzcx-0004h1-Dk for qemu-devel@nongnu.org; Mon, 31 Oct 2011 17:42:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKzcv-00069i-MU for qemu-devel@nongnu.org; Mon, 31 Oct 2011 17:42:43 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:36356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKzcv-00069M-Jm for qemu-devel@nongnu.org; Mon, 31 Oct 2011 17:42:41 -0400 Received: from /spool/local by e5.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 31 Oct 2011 17:38:35 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9VLcRAD307846 for ; Mon, 31 Oct 2011 17:38:27 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9VLcQfE030236 for ; Mon, 31 Oct 2011 17:38:26 -0400 Message-ID: <4EAF1550.9080107@us.ibm.com> Date: Mon, 31 Oct 2011 16:38:24 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4EAF13A8.5020303@weilnetz.de> In-Reply-To: <4EAF13A8.5020303@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , QEMU Developers , Aurelien Jarno On 10/31/2011 04:31 PM, Stefan Weil wrote: > Hi, > > this is a 3rd version of the patch series which adds support for > QEMU on any host by using a TCG interpreter (TCI). > > Version 2 was sent to the list and is available here: > http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg02504.html > > The new version removed the TRACE macros which I used during development. > They are no longer needed. This fixes malc's feedback. > > Patches 1, 2, 5 and 6 are only rebased. > > Patch 1 is useful even without TCI and improves the handling of a > special case needed for PPC hosts. > > Please tell me if I should send the complete patches to qemu-devel. > > I'd appreciate if the series could be pulled before QEMU 1.0 to form > a base for further development of TCI. I'll defer to Blue and/or Aurelien here as I don't know enough about TCG to really review this series. But I'd recommend waiting to pull this until after 1.1 opens up. This is the sort of thing that 1) people are likely to actually use and 2) could use a full development cycle of testing to get hardened before showing up in a release. I'd feel better about pulling this into 1.0 if it was guarded by a configure option and disabled by default just to enforce that it's an experimental feature. Regards, Anthony Liguori > > Regards, > Stefan Weil > > > The following changes since commit ff74c5a9a91c6dbf1017195462aa4176f7381240: > > Merge remote-tracking branch 'riku/linux-user-for-upstream' into staging > (2011-10-31 15:05:40 -0500) > > are available in the git repository at: > > git://qemu.weilnetz.de/qemu.git tci > > Stefan Weil (6): > tcg: TCG targets may define tcg_qemu_tb_exec > tcg: Make ARRAY_SIZE(tcg_op_defs) globally available > tcg: Add bytecode generator for tcg interpreter > tcg: Add interpreter for bytecode > tcg: Add tci disassembler > tcg: Add tcg interpreter to configure / make > > Makefile.target | 4 + > configure | 34 ++- > dis-asm.h | 1 + > disas.c | 4 +- > dyngen-exec.h | 12 +- > exec-all.h | 22 +- > tcg/ppc/tcg-target.h | 4 + > tcg/tcg.c | 1 + > tcg/tcg.h | 12 +- > tcg/tci/README | 130 ++++++ > tcg/tci/tcg-target.c | 906 +++++++++++++++++++++++++++++++++++++ > tcg/tci/tcg-target.h | 160 +++++++ > tci-dis.c | 59 +++ > tci.c | 1208 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 14 files changed, 2545 insertions(+), 12 deletions(-) > create mode 100644 tcg/tci/README > create mode 100644 tcg/tci/tcg-target.c > create mode 100644 tcg/tci/tcg-target.h > create mode 100644 tci-dis.c > create mode 100644 tci.c > > >