qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode
Date: Mon, 31 Oct 2011 17:06:17 -0500	[thread overview]
Message-ID: <4EAF1BD9.4000908@codemonkey.ws> (raw)
In-Reply-To: <4EAF1B0F.90500@weilnetz.de>

On 10/31/2011 05:02 PM, Stefan Weil wrote:
> Am 31.10.2011 22:38, schrieb Anthony Liguori:
>>
>> I'll defer to Blue and/or Aurelien here as I don't know enough about TCG to
>> really review this series.
>>
>> But I'd recommend waiting to pull this until after 1.1 opens up. This is the
>> sort of thing that 1) people are likely to actually use and 2) could use a
>> full development cycle of testing to get hardened before showing up in a release.
>>
>> I'd feel better about pulling this into 1.0 if it was guarded by a configure
>> option and disabled by default just to enforce that it's an experimental feature.
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> The current version of TCI is only activated with configure
> --enable-tcg-interpreter
> (see http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg02509.html),
> so this should be safe for 1.0. And yes, it's still an experimental feature.

Okay, then I really don't have an objection, but would still prefer Blue or 
Aurel to Ack it explicitly.

> It's up to the maintainers of (Linux) distributions when they will add QEMU with
> TCI
> for new hosts which were unsupported by native TCG. It won't work automatically -
> they have to add the configure option for it. I have no access to such hosts for
> testing,
> but offer any help I can give.

Indeed.  It's a good feature to have.  Just thinking about release stability.  I 
don't want to ship a brand new feature as part of the 1.0 release and have 
people have a bad experience due to it.

Regards,

Anthony Liguori

> Regards,
>
> Stefan Weil
>
>

  reply	other threads:[~2011-10-31 22:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 21:31 [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode Stefan Weil
2011-10-31 21:38 ` Anthony Liguori
2011-10-31 22:02   ` Stefan Weil
2011-10-31 22:06     ` Anthony Liguori [this message]
2011-11-01 19:30       ` Blue Swirl
2011-11-02 20:55 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAF1BD9.4000908@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aurelien@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).