From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL6WB-0007fz-Vr for qemu-devel@nongnu.org; Tue, 01 Nov 2011 01:04:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL6WA-0004db-Ur for qemu-devel@nongnu.org; Tue, 01 Nov 2011 01:04:11 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:58308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL6WA-0004U4-9K for qemu-devel@nongnu.org; Tue, 01 Nov 2011 01:04:10 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp01.in.ibm.com (8.14.4/8.13.1) with ESMTP id pA15406V007836 for ; Tue, 1 Nov 2011 10:34:00 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA153xn22957354 for ; Tue, 1 Nov 2011 10:34:00 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA153xjZ032138 for ; Tue, 1 Nov 2011 16:03:59 +1100 Received: from [9.115.122.62] ([9.115.122.62]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pA153w0D029821 for ; Tue, 1 Nov 2011 16:03:59 +1100 Message-ID: <4EAF7D8C.8050601@linux.vnet.ibm.com> Date: Tue, 01 Nov 2011 13:03:08 +0800 From: ShaoHe Feng MIME-Version: 1.0 References: <1319560018-25788-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1319560018-25788-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: report TRAY_STATE_CHANGED events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org test-by: ShaoHe Feng It seems this patch can not work well. there is my test process. I startup a guest by the follow option: -drive file=/home/fsh/image/OCDC-natty-Test-Drive-20110823_010339.iso,if=ide,index=1,media=cdrom after the guest startups, then I right click mouse in the UI of the guest, and select the Eject from the menu. there comes an event in the qmp-monitor. {"timestamp": {"seconds": 1320118137, "microseconds": 420150}, "event": "TRAY_STATE_CHANGED", "data": {"device": "ide0-cd1", "state": "open"}} however, if I change the cdrom by this command: { "execute": "change","arguments": { "device": "ide0-cd1", "target": "/home/fsh/image/OCDC-natty-Test-Drive-20110823_010339.iso" } } there is no any event. and { "execute": "eject", "arguments": { "device": "ide0-cd1" } }, there is also no any event. only I right click mouse in the UI of the guest, qmp-monitor can receive an TRAY_STATE_CHANGED event. , Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > QMP/qmp-events.txt | 20 ++++++++++++++++++++ > block.c | 9 +++++++++ > monitor.c | 3 +++ > monitor.h | 1 + > 4 files changed, 33 insertions(+), 0 deletions(-) > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index 0ce5d4e..242c7a5 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -264,3 +264,23 @@ Example: > > Note: If action is "reset", "shutdown", or "pause" the WATCHDOG event is > followed respectively by the RESET, SHUTDOWN, or STOP events. > + > + > +TRAY_STATE_CHANGED > +------------------ > + > +Emitted when the state of a CD-ROM tray changes. > + > +Data: > + > +- "device": device name (json-string) > +- "state": state of the tray, one of the following (json-string) > + "open": tray is open > + "closed": tray is closed > + > +Example: > + > +{ "event": "TRAY_STATE_CHANGED", > + "data": { "device": "ide0-cd0", > + "state": "open" }, > + "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > diff --git a/block.c b/block.c > index 9873b57..7b0aa62 100644 > --- a/block.c > +++ b/block.c > @@ -2968,10 +2968,19 @@ int bdrv_media_changed(BlockDriverState *bs) > void bdrv_eject(BlockDriverState *bs, int eject_flag) > { > BlockDriver *drv = bs->drv; > + QObject *data; > > if (drv&& drv->bdrv_eject) { > drv->bdrv_eject(bs, eject_flag); > } > + > + if (*bs->device_name) { > + data = qobject_from_jsonf("{ 'device': %s, 'state': %s }", > + bs->device_name, > + eject_flag ? "open" : "closed"); > + monitor_protocol_event(QEVENT_TRAY_STATE_CHANGED, data); > + qobject_decref(data); > + } > } > > /** > diff --git a/monitor.c b/monitor.c > index ffda0fe..516a789 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -482,6 +482,9 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) > case QEVENT_SPICE_DISCONNECTED: > event_name = "SPICE_DISCONNECTED"; > break; > + case QEVENT_TRAY_STATE_CHANGED: > + event_name = "TRAY_STATE_CHANGED"; > + break; > default: > abort(); > break; > diff --git a/monitor.h b/monitor.h > index 4f2d328..b8f4bf7 100644 > --- a/monitor.h > +++ b/monitor.h > @@ -35,6 +35,7 @@ typedef enum MonitorEvent { > QEVENT_SPICE_CONNECTED, > QEVENT_SPICE_INITIALIZED, > QEVENT_SPICE_DISCONNECTED, > + QEVENT_TRAY_STATE_CHANGED, > QEVENT_MAX, > } MonitorEvent; >