* [Qemu-devel] [PATCH] block.c typo in comment fixed
@ 2011-11-01 1:36 matthias.bgg
2011-11-01 7:24 ` Stefan Weil
2011-11-01 8:39 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: matthias.bgg @ 2011-11-01 1:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Matthias Brugger
From: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 9bb236c..480aae2 100644
--- a/block.c
+++ b/block.c
@@ -497,7 +497,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename,
open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
/*
- * Snapshots should be writable.
+ * Snapshots should be writeable.
*/
if (bs->is_temporary) {
open_flags |= BDRV_O_RDWR;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block.c typo in comment fixed
2011-11-01 1:36 [Qemu-devel] [PATCH] block.c typo in comment fixed matthias.bgg
@ 2011-11-01 7:24 ` Stefan Weil
2011-11-01 8:39 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2011-11-01 7:24 UTC (permalink / raw)
To: Matthias Brugger; +Cc: qemu-devel
Am 01.11.2011 02:36, schrieb matthias.bgg@googlemail.com:
> From: Matthias Brugger<matthias.bgg@gmail.com>
>
>
> Signed-off-by: Matthias Brugger<matthias.bgg@gmail.com>
> ---
> block.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block.c b/block.c
> index 9bb236c..480aae2 100644
> --- a/block.c
> +++ b/block.c
> @@ -497,7 +497,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename,
> open_flags = flags& ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
>
> /*
> - * Snapshots should be writable.
> + * Snapshots should be writeable.
> */
> if (bs->is_temporary) {
> open_flags |= BDRV_O_RDWR;
Hi Matthias,
both writable and writeable seem to be correct,
but http://oxforddictionaries.com/ says that writable is the only
correct spelling.
Therefore your patch should not be used.
Cheers,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block.c typo in comment fixed
2011-11-01 1:36 [Qemu-devel] [PATCH] block.c typo in comment fixed matthias.bgg
2011-11-01 7:24 ` Stefan Weil
@ 2011-11-01 8:39 ` Stefan Hajnoczi
2011-11-01 11:53 ` Matthias
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2011-11-01 8:39 UTC (permalink / raw)
To: matthias.bgg; +Cc: Matthias Brugger, qemu-devel
On Tue, Nov 01, 2011 at 01:36:42AM +0000, matthias.bgg@googlemail.com wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> block.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
"Writable" is also a common spelling. Try git grep writable and compare
against git grep writeable. In qemu.git "writable" actually dominates
by a large majority so we should leave this alone.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block.c typo in comment fixed
2011-11-01 8:39 ` Stefan Hajnoczi
@ 2011-11-01 11:53 ` Matthias
0 siblings, 0 replies; 4+ messages in thread
From: Matthias @ 2011-11-01 11:53 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: matthias.bgg, qemu-devel
On 11/01/2011 08:39 AM, Stefan Hajnoczi wrote:
> On Tue, Nov 01, 2011 at 01:36:42AM +0000, matthias.bgg@googlemail.com wrote:
>> From: Matthias Brugger<matthias.bgg@gmail.com>
>>
>>
>> Signed-off-by: Matthias Brugger<matthias.bgg@gmail.com>
>> ---
>> block.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> "Writable" is also a common spelling. Try git grep writable and compare
> against git grep writeable. In qemu.git "writable" actually dominates
> by a large majority so we should leave this alone.
>
> Stefan
Alright, I didn't know that. Sorry for the noise.
Regards,
Matthias
--
---
http://motzblog.wordpress.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-01 10:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-01 1:36 [Qemu-devel] [PATCH] block.c typo in comment fixed matthias.bgg
2011-11-01 7:24 ` Stefan Weil
2011-11-01 8:39 ` Stefan Hajnoczi
2011-11-01 11:53 ` Matthias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).