From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39322)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLG02-00029X-RP
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 11:11:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLFzw-0007ZB-Px
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 11:11:38 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:49065)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLFzw-0007Z3-MD
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 11:11:32 -0400
Received: by gya6 with SMTP id 6so3687017gya.4
	for <qemu-devel@nongnu.org>; Tue, 01 Nov 2011 08:11:32 -0700 (PDT)
Message-ID: <4EB00AA9.5060505@codemonkey.ws>
Date: Tue, 01 Nov 2011 10:05:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <CA+g7VZ2g0CdpYWY+wUuOk3Oi-C_penszMaJvF1VJCt0+tzRn0Q@mail.gmail.com>
In-Reply-To: <CA+g7VZ2g0CdpYWY+wUuOk3Oi-C_penszMaJvF1VJCt0+tzRn0Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [patch] remove unused function arg in
 qemu_iohandler_poll() and qemu_iohandler_fill()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jun Koi <junkoi2004@gmail.com>
Cc: qemu-devel@nongnu.org

On 11/01/2011 12:11 AM, Jun Koi wrote:
> This patch removes unused function argument xfds from
> qemu_iohandler_poll() and qemu_iohandler_fill()
>
> Signed-off-by: Jun Koi<junkoi2004@gmail.com>
>
>
> diff --git a/iohandler.c b/iohandler.c
> index 5640d49..9963790 100644
> --- a/iohandler.c
> +++ b/iohandler.c
> @@ -89,7 +89,7 @@ int qemu_set_fd_handler(int fd,
>       return qemu_set_fd_handler2(fd, NULL, fd_read, fd_write, opaque);
>   }
>
> -void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set
> *writefds, fd_set *xfds)

Your mailer is munging the patch.  Please use git-send-email to avoid this.

Regards,

Anthony Liguori

> +void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set *writefds)
>   {
>       IOHandlerRecord *ioh;
>
> @@ -111,7 +111,7 @@ void qemu_iohandler_fill(int *pnfds, fd_set
> *readfds, fd_set *writefds, fd_set *
>       }
>   }
>
> -void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, fd_set
> *xfds, int ret)
> +void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, int ret)
>   {
>       if (ret>  0) {
>           IOHandlerRecord *pioh, *ioh;
> diff --git a/main-loop.c b/main-loop.c
> index 60e9748..7cbb0b0 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -446,7 +446,7 @@ int main_loop_wait(int nonblocking)
>   #ifdef CONFIG_SLIRP
>       slirp_select_fill(&nfds,&rfds,&wfds,&xfds);
>   #endif
> -    qemu_iohandler_fill(&nfds,&rfds,&wfds,&xfds);
> +    qemu_iohandler_fill(&nfds,&rfds,&wfds);
>       glib_select_fill(&nfds,&rfds,&wfds,&xfds,&tv);
>
>       if (timeout>  0) {
> @@ -460,7 +460,7 @@ int main_loop_wait(int nonblocking)
>       }
>
>       glib_select_poll(&rfds,&wfds,&xfds, (ret<  0));
> -    qemu_iohandler_poll(&rfds,&wfds,&xfds, ret);
> +    qemu_iohandler_poll(&rfds,&wfds, ret);
>   #ifdef CONFIG_SLIRP
>       slirp_select_poll(&rfds,&wfds,&xfds, (ret<  0));
>   #endif
> diff --git a/main-loop.h b/main-loop.h
> index 8a716b1..f753c6a 100644
> --- a/main-loop.h
> +++ b/main-loop.h
> @@ -341,8 +341,8 @@ void qemu_mutex_unlock_iothread(void);
>
>   /* internal interfaces */
>
> -void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set
> *writefds, fd_set *xfds);
> -void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, fd_set
> *xfds, int rc);
> +void qemu_iohandler_fill(int *pnfds, fd_set *readfds, fd_set *writefds);
> +void qemu_iohandler_poll(fd_set *readfds, fd_set *writefds, int rc);
>
>   void qemu_bh_schedule_idle(QEMUBH *bh);
>   int qemu_bh_poll(void);
> (END)
>
>