From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLGIs-0007ZM-Ee for qemu-devel@nongnu.org; Tue, 01 Nov 2011 11:31:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLGIo-0003qP-51 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 11:31:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51812 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLGIn-0003q7-N0 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 11:31:01 -0400 Message-ID: <4EB0106E.90801@suse.de> Date: Tue, 01 Nov 2011 16:29:50 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1320159390-29797-1-git-send-email-kraxel@redhat.com> <1320159390-29797-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1320159390-29797-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] usb: change VID/PID for usb-hub and usb-msd to prevent conflict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Roy Tam Cc: qemu-devel@nongnu.org Am 01.11.2011 15:56, schrieb Gerd Hoffmann: > From: Roy Tam >=20 > Some USB drivers, for example USBASPI.SYS, will skip different type of > device which has same VID/PID. The following patch helps preventing > usb-msd being skipped by the driver. >=20 > Sign-off-by: Roy Tam Typo? Andreas > Signed-off-by: Gerd Hoffmann > --- > hw/usb-hub.c | 4 ++-- > hw/usb-msd.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/usb-hub.c b/hw/usb-hub.c > index 7b47079..3eb0f1a 100644 > --- a/hw/usb-hub.c > +++ b/hw/usb-hub.c > @@ -127,8 +127,8 @@ static const USBDescDevice desc_device_hub =3D { > =20 > static const USBDesc desc_hub =3D { > .id =3D { > - .idVendor =3D 0, > - .idProduct =3D 0, > + .idVendor =3D 0x0409, > + .idProduct =3D 0x55aa, > .bcdDevice =3D 0x0101, > .iManufacturer =3D STR_MANUFACTURER, > .iProduct =3D STR_PRODUCT, > diff --git a/hw/usb-msd.c b/hw/usb-msd.c > index 1a0815a..b734177 100644 > --- a/hw/usb-msd.c > +++ b/hw/usb-msd.c > @@ -162,8 +162,8 @@ static const USBDescDevice desc_device_high =3D { > =20 > static const USBDesc desc =3D { > .id =3D { > - .idVendor =3D 0, > - .idProduct =3D 0, > + .idVendor =3D 0x46f4, /* CRC16() of "QEMU" */ > + .idProduct =3D 0x0001, > .bcdDevice =3D 0, > .iManufacturer =3D STR_MANUFACTURER, > .iProduct =3D STR_PRODUCT, --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg