From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLHLx-0005Z9-Ty for qemu-devel@nongnu.org; Tue, 01 Nov 2011 12:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLHLs-0005nc-AQ for qemu-devel@nongnu.org; Tue, 01 Nov 2011 12:38:21 -0400 Received: from fmmailgate06.web.de ([217.72.192.247]:36512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLHLs-0005nS-1q for qemu-devel@nongnu.org; Tue, 01 Nov 2011 12:38:16 -0400 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate06.web.de (Postfix) with ESMTP id 77C6FACA127 for ; Tue, 1 Nov 2011 17:38:14 +0100 (CET) Message-ID: <4EB0202E.50701@web.de> Date: Tue, 01 Nov 2011 17:37:02 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1320088682-12958-1-git-send-email-andreas.faerber@web.de> <1320088682-12958-3-git-send-email-andreas.faerber@web.de> <47C91597-B6B1-4351-9DC3-30E405EC480B@sunshineco.com> In-Reply-To: <47C91597-B6B1-4351-9DC3-30E405EC480B@sunshineco.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Sunshine Cc: Peter Maydell , Juan Pineda , qemu-devel@nongnu.org Am 01.11.2011 09:09, schrieb Eric Sunshine: > Perhaps the following alternative solution would be more palatable? It's > still tremendously ugly, but is localized to cocoa.m, thus less intrusive. > > -- >8 -- > Subject: [PATCH] softfloat: Avoid uint16 type conflict on Darwin > > cocoa.m includes indirectly via . > cssmconfig.h defines type uint16 which unfortunately conflicts with the > definition in qemu's softfloat.h, thus resulting in compilation failure. > To work around the problem, #define _UINT16, which informs cssmconfig.h > that uint16 is already defined and that it should not apply its own > definition. Thanks for the suggestion! _UINT16 is an interesting suggestion, however softfloat's uint16 is not uint16_t but int, so I'd rather not do it that way around. (I had also decided against the AIX path of never defining uint16 and always using system definitions, since that wouldn't work outside Cocoa code.) Do you have any thoughts about the include path issue? If we could keep QEMU code from getting into #import then we could redefine the system type instead, in cocoa.m. Andreas