From: Gerd Hoffmann <kraxel@redhat.com>
To: John Baboval <john.baboval@virtualcomputer.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution
Date: Tue, 01 Nov 2011 17:57:11 +0100 [thread overview]
Message-ID: <4EB024E7.8040400@redhat.com> (raw)
In-Reply-To: <2F227323-6B37-4F64-843A-91C3291A9254@virtualcomputer.com>
On 11/01/11 14:39, John Baboval wrote:
> I don't know of any reason for it.
I'd guess it is alignment, probably not important for all color depts.
Maybe it is a good idea to do all sanity checks in the
VBE_DISPI_INDEX_ENABLE branch where the actual mode switch happens. Then
you already know xres, yres and depth when applying the checks. You can
calculate the scanline length, then check the scanline alignment instead
of being overly strict on xres in high color modes to satisfy alignment
requirements in low color modes.
You can also simply calculate how much memory the video mode needs and
check that against the configured video ram instead of pulling xres and
yres limits out of thin air.
cheers,
Gerd
next prev parent reply other threads:[~2011-11-01 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 19:24 [Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution John Baboval
2011-11-01 8:58 ` Gerd Hoffmann
2011-11-01 13:39 ` John Baboval
2011-11-01 16:57 ` Gerd Hoffmann [this message]
2011-11-03 15:03 ` John Baboval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB024E7.8040400@redhat.com \
--to=kraxel@redhat.com \
--cc=john.baboval@virtualcomputer.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).