* [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X
@ 2011-11-01 9:39 Eric Sunshine
2011-11-01 18:04 ` Anthony Liguori
2011-11-01 18:39 ` Andreas Färber
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sunshine @ 2011-11-01 9:39 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Eric Sunshine, David Gibson
qemu-barrier.h tests if macro __powerpc__ is defined, however, the
preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
__powerpc__. Resolve by testing instead for qemu-provided _ARCH_PPC.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
The anomalous __powerpc__ test appears only in qemu-barrier.h.
No other source files reference this name.
Cc: David Gibson <david@gibson.dropbear.id.au>
qemu-barrier.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-barrier.h b/qemu-barrier.h
index 735eea6..c11bb2b 100644
--- a/qemu-barrier.h
+++ b/qemu-barrier.h
@@ -14,7 +14,7 @@
*/
#define smp_wmb() barrier()
-#elif defined(__powerpc__)
+#elif defined(_ARCH_PPC)
/*
* We use an eieio() for a wmb() on powerpc. This assumes we don't
--
1.7.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X
2011-11-01 9:39 [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X Eric Sunshine
@ 2011-11-01 18:04 ` Anthony Liguori
2011-11-01 18:39 ` Andreas Färber
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2011-11-01 18:04 UTC (permalink / raw)
To: Eric Sunshine; +Cc: qemu-trivial, qemu-devel, David Gibson
On 11/01/2011 04:39 AM, Eric Sunshine wrote:
> qemu-barrier.h tests if macro __powerpc__ is defined, however, the
> preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
> __powerpc__. Resolve by testing instead for qemu-provided _ARCH_PPC.
>
> Signed-off-by: Eric Sunshine<sunshine@sunshineco.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> The anomalous __powerpc__ test appears only in qemu-barrier.h.
> No other source files reference this name.
>
> Cc: David Gibson<david@gibson.dropbear.id.au>
>
> qemu-barrier.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 735eea6..c11bb2b 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -14,7 +14,7 @@
> */
> #define smp_wmb() barrier()
>
> -#elif defined(__powerpc__)
> +#elif defined(_ARCH_PPC)
>
> /*
> * We use an eieio() for a wmb() on powerpc. This assumes we don't
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X
2011-11-01 9:39 [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X Eric Sunshine
2011-11-01 18:04 ` Anthony Liguori
@ 2011-11-01 18:39 ` Andreas Färber
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2011-11-01 18:39 UTC (permalink / raw)
To: Eric Sunshine; +Cc: qemu-trivial, qemu-devel, David Gibson
Am 01.11.2011 10:39, schrieb Eric Sunshine:
> qemu-barrier.h tests if macro __powerpc__ is defined, however, the
> preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
> __powerpc__.
> Resolve by testing instead for qemu-provided _ARCH_PPC.
This part is actually wrong: _ARCH_PPC is compiler-provided.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
I currently don't have access to my ppc64 box, so
Reviewed-by: Andreas Färber <andreas.faerber@web.de>
Next time please cc malc (TCG ppc) and me (Darwin) on this.
Thanks,
Andreas
> ---
>
> The anomalous __powerpc__ test appears only in qemu-barrier.h.
> No other source files reference this name.
>
> Cc: David Gibson <david@gibson.dropbear.id.au>
>
> qemu-barrier.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 735eea6..c11bb2b 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -14,7 +14,7 @@
> */
> #define smp_wmb() barrier()
>
> -#elif defined(__powerpc__)
> +#elif defined(_ARCH_PPC)
>
> /*
> * We use an eieio() for a wmb() on powerpc. This assumes we don't
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-01 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-01 9:39 [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X Eric Sunshine
2011-11-01 18:04 ` Anthony Liguori
2011-11-01 18:39 ` Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).